Closed CrackTheCode016 closed 1 year ago
Thank you for catching that!! Let me know if there is anything else you think would be wise to include/changed.
For reference, the XCM v3 PR is here: https://github.com/paritytech/polkadot/pull/4097, make sure that every new feature mentioned in the description there is reflected on this PR.
Junction
also changed more than this diff would imply: GeneralKey
and all items which contained a network
field also changed.
@gavofyork Currently we describe most of the errors of the xcvm instructions as fallible or infallible. Do we want to change these error descriptions to the actual errors mentioned in the 8 The types of error in XCM
section based on the implementation in the xcm-executor?
Maybe not relevant for this PR, but would including hyperlinks to the xcm code in the Polkadot repo be interesting? I feel it would bring the spec more cohesion.
i.e., to specific instructions, or interfaces like XcmContext
etc
@gavofyork Currently we describe most of the errors of the xcvm instructions as fallible or infallible. Do we want to change these error descriptions to the actual errors mentioned in the
8 The types of error in XCM
section based on the implementation in the xcm-executor?
Yes - that could be helpful.
Maybe not relevant for this PR, but would including hyperlinks to the xcm code in the Polkadot repo be interesting? I feel it would bring the spec more cohesion.
i.e., to specific instructions, or interfaces like
XcmContext
etc
Sounds sensible.
In an effort to sync, update, and expand the documentation around XCM in the Polkadot Wiki, I propose adding the newly added instructions and registers.
Most of the definitions for the instructions came from the XCM v3 commit code in the Polkadot repo.
Instructions Added:
ExpectAsset
ExpectError
ExpectOrigin
QueryPallet
ExpectPallet
ReportTransactStatus
ClearTransactStatus
LockAsset
UnlockAsset
NoteUnlockable
RequestUnlock
Registers Added:
TODO
MultiLocation
Junction
GeneralKey
network
fieldsMultiAsset
/WildMultiAsset
max_assets
removalNetworkId
BodyId
/BodyPart
UniversalLocation
(for the GlobalConsensus Junction)