search

pollen-robotics / reachy2-sdk

Reachy 2 Python SDK
https://www.pollen-robotics.com
Apache License 2.0
5 stars 0 forks source link

Why is pid in both build_grpc_cmd_msg() and build_grpc_cmd_msg_actuator() methods? #84

Closed simheo closed 1 year ago

simheo commented 1 year ago

https://github.com/pollen-robotics/reachy-v2-sdk/blob/75b0686d4753349a56edcfcb9af1ab0dd645b7e6/src/reachy_v2_sdk/orbita2d.py#L114-L163

glannuzel commented 1 year ago

This is only cause I enable the user to do: reachy.r_arm.shoulder._motors['motor_1'].pid = (p, i, d)

I can remove this and allow only modification at actuator level.

simheo commented 1 year ago

Closing this issue, as it will be adressed in #136.