Vectorize `discrete` parameter of `estimate_mi`

polsys / ennemi

Easy Nearest Neighbor Estimation of Mutual Information

https://polsys.github.io/ennemi/

MIT License

35 stars 12 forks source link

Vectorize `discrete` parameter of `estimate_mi` #100

Open polsys opened 2 years ago

polsys commented 2 years ago

Related to #89 and #88. I can't remember if the non-vectorization in estimate_mi was a conscious decision or an oversight (as pairwise_mi is vectorized). This might need some design thinking, therefore did not include in 1.1.1.

[ ] Vectorize the parameter
[ ] Update the check for conditioning variable
[ ] Update the normalization warning

polsys commented 2 years ago

I'm concerned that this might introduce some new edge cases that I forget to test for... This should be implemented (or at least started) by somebody who actually needs the feature.

This issue is up for grabs! 😄