polymorphicshade / NewPipe

A fork of NewPipe with SponsorBlock functionality.
GNU General Public License v3.0
3.2k stars 104 forks source link

f-droid #8

Open bingoxo opened 3 years ago

bingoxo commented 3 years ago

can you please add your fork to f-droid so it can have a larger audience and at same time we can have automatic updates

emacsomancer commented 3 years ago

preferably also via a separate repo like the main newpipe does; fdroid sometimes takes a while to roll out updates

ajayyy commented 3 years ago

Depends on https://github.com/polymorphicshade/NewPipe/issues/12

seniorm0ment commented 3 years ago

+1, main repo and a hosted one or maybe izzy's repo.

je-vv commented 3 years ago

I'd also say both, the official one, and a custom onel with faster updates, like the newpipe one, but keeping the same f-droid FLOSS policies on the custom one... Thanks !

Shallrath commented 3 years ago

This is the main reason that's keeping me from using this: Newpipe needs frequent updates so it won't stop working with YouTube. Keeping an app updated manually on multiple devices is much more effort than just skipping sponsored segments manually...

bingoxo commented 3 years ago

This is the main reason that's keeping me from using this: Newpipe needs frequent updates so it won't stop working with YouTube. Keeping an app updated manually on multiple devices is much more effort than just skipping sponsored segments manually...

the updates are not that frequent plus fdroid updates the same way newpipe updates unless you are rooted (which is bad for security anyway)

seniorm0ment commented 3 years ago

fdroid does some verifications, not all repos but their main and izzy's repo i know do

bingoxo commented 3 years ago

fdroid does some verifications, not all repos but their main and izzy's repo i know do

the advantage of using fdroid's main repo is that you trust them to build from source instead of downloading whatever binary the main dev puts in releases , but again , unless you audit the code yourself you still need to trust the dev anyway

izzy afaik just grabs binaries from releases

seniorm0ment commented 3 years ago

https://apt.izzysoft.de/fdroid/index/info I meant more the malware and library scans, but yeah of course I'd prefer the main repo if possible.

but again , unless you audit the code yourself you still need to trust the dev anyway

as with anything

frequent updates

It doesn't need frequent updates but there are times where Google does something and Newpipe fixes it then a day later it's broken again then a few more times then Newpipe is fine for months if not longer. It's just when it breaks, you need that update pretty quickly otherwise the the app is useless. f google.

mooreye commented 2 years ago

I would prefer a repo with only NewPipe x SponsorBlock, as Izzy contains proprietary software. On a side note, is this app capable of self-updating? The "show notification if update available" option is still there, but when I tap "Check for updates", there is no feedback at all. If the app could just grab newest release from GitHub automatically, it would be good enough for me (Signal does something similar).

EDIT: Well it's not, I had to download APK manually...

CodeCubeNeo commented 2 years ago

Any updates on this?

gilbsgilbs commented 2 years ago

Just submitted https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11402 . We'll see where this goes. 🤞

Atemu commented 2 years ago

We'd probably want to wait for the Tubular rebranding. That might entail a new app ID.

gilbsgilbs commented 2 years ago

I'll leave it in draft then. Please let me know when the rebranding happens. It may also be needed to update the fastlane metadata btw.

I'd argue against an app id change though because it's rather internal and will mostly cause upgrade issues to users, who will likely have to reimport their subscriptions and recreate their preferences.

trymeouteh commented 2 years ago

preferably also via a separate repo like the main newpipe does; fdroid sometimes takes a while to roll out updates

Agreed

licaon-kter commented 1 year ago

no news?

Mynacol commented 11 months ago

I'm working on a new build recipe, but currently the build fails due to missing dependencies on jitpack.io. The newest NewPipe commits don't have this problem, so I'd wait for version 0.26.

But until then we should figure out if any rebranding is wanted/needed for F-Droid inclusion.

Compilation error ``` $ ./gradlew build > Task :app:mergeReleaseNativeLibs FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':app:mergeReleaseNativeLibs'. > Could not resolve all files for configuration ':app:releaseRuntimeClasspath'. > Could not find com.github.TeamNewPipe.NewPipeExtractor:extractor:v0.22.7. Searched in the following locations: - https://dl.google.com/dl/android/maven2/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom - https://repo.maven.apache.org/maven2/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom - https://jitpack.io/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom - https://repo.clojars.org/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom Required by: project :app > com.github.TeamNewPipe:NewPipeExtractor:v0.22.7 > Could not find com.github.TeamNewPipe.NewPipeExtractor:NewPipeExtractor:v0.22.7. Searched in the following locations: - https://dl.google.com/dl/android/maven2/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom - https://repo.maven.apache.org/maven2/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom - https://jitpack.io/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom - https://repo.clojars.org/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom Required by: project :app > com.github.TeamNewPipe:NewPipeExtractor:v0.22.7 > Could not find com.github.TeamNewPipe.NewPipeExtractor:timeago-parser:v0.22.7. Searched in the following locations: - https://dl.google.com/dl/android/maven2/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom - https://repo.maven.apache.org/maven2/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom - https://jitpack.io/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom - https://repo.clojars.org/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom Required by: project :app > com.github.TeamNewPipe:NewPipeExtractor:v0.22.7 * Try: > Run with --stacktrace option to get the stack trace. > Run with --info or --debug option to get more log output. > Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 19s 5 actionable tasks: 4 executed, 1 up-to-date ```