polymorphicshade / Tubular

A fork of NewPipe that implements SponsorBlock and ReturnYouTubeDislike.
GNU General Public License v3.0
1.64k stars 42 forks source link

Upstream 27.2 #128

Closed asandikci closed 3 months ago

asandikci commented 3 months ago

Update: Release on the way πŸ₯³ v0.27.2


This is a friendly reminder, upstream Newpipe released 27.2 version for new 403 error fix. We would be thankful if you could merge in your spare time.

Thanks in advance !

TheRedCyclops commented 3 months ago

I made a quick debug build with the changes from upstream, you can use it in the meantime Tubular-fix.apk.zip

MuerteRoja commented 3 months ago

I made a quick debug build with the changes from upstream, you can use it in the meantime Tubular-fix.apk.zip

@Glich440 In principle, I had downloaded Pulsar (a local MP3 player) on one of these typical apk mod websites in its premium version, to download the songs that I usually listen to with Tubular through YouTube to MP3 converters and thus be able to listen to them locally on that player, just now that I am seeing this issue and your comment, I must thank you for sharing the file with us, as a consumer, I understand that the developer of this application, as @polymorphicshade is, has responsibilities and other occupations to attend to in real life behind the screen, and, precisely thanks to you (and partly thanks to the MP3 player application that I had previously downloaded) I don't care how much time the developer takes to upload an update the application (Tubular), although your Tubular Debug application is starting to give me errors, I just have to go back to the MP3 player and that's it, it's that simple and easy. Thank you for your solidarity my friend. I am very grateful. πŸ‘

profucius commented 3 months ago

I made a quick debug build with the changes from upstream, you can use it in the meantime Tubular-fix.apk.zip

This does work. Unfortunately because its a new package name, it's appdata is separate, which means that it forks my viewing history etc. I know its just for debugging purposes, but I rely on keeping my watch history. I suppose I'll have to wait for the official, but thank you anyway.

njanbobby commented 3 months ago

I made a quick debug build with the changes from upstream, you can use it in the meantime Tubular-fix.apk.zip

This does work. Unfortunately because its a new package name, it's appdata is separate, which means that it forks my viewing history etc. I know its just for debugging purposes, but I rely on keeping my watch history. I suppose I'll have to wait for the official, but thank you anyway.

You could export database from the Tubular app, and restore it in the temp app. Atleast that's how I keep my history and subscriptions

tuxayo commented 3 months ago

@Glich440 did you need to solve conflicts in the code to make that build?

If for hotfixes, conflicts rarely happen, the Tubular project could have a CI/CD that when a new tag is pushed upstream, it would rebase Tubular and build and publish a debug APK automatically. (assuming a volunteer has time to setup such an automated build)

TheRedCyclops commented 3 months ago

a few small ones

asandikci commented 3 months ago

Hello again. I'm a daily YouTube (NewPipe/Tubular) user. So I want to build NewPipe + Tubular with my own in a separate repo. if you're impatient like me and want to access the working application now you can visit MaintainTeam/LastPipeBender. This is a Release build (not debug), signed with my keys and includes both tubular/newpipe latest master branches (plus a mini rebranding). Also build is generated with Github Actions CI/CD 😊

Also a PR for merging latest NewPipe hotfix is on the way (see https://github.com/polymorphicshade/Tubular/pull/129). You can wait for it to be merged

xray commented 3 months ago

@asandikci We'll see, I would like it if we could all just get behind Tubular. It does what y'all want it to, y'all are just unsatisfied with the release pace. Which is understandable when it's something as commonly used as YT. I did my best with my pull requests to follow the same pattern as @polymorphicshade when merging with upstream but I'm not 100% sure if it's to spec.

MuerteRoja commented 3 months ago

Hello again. I'm a daily YouTube (NewPipe/Tubular) user. So I want to build NewPipe + Tubular with my own in a separate repo. if you're impatient like me and want to access the working application now you can visit MaintainTeam/LastPipeBender. This is a Release build (not debug), signed with my keys and includes both tubular/newpipe latest master branches (plus a mini rebranding). Also build is generated with Github Actions CI/CD 😊

Also a PR for merging latest NewPipe hotfix is on the way (see #129). You can wait for it to be merged

May I ask what is the difference between your project and Newpipe and Tubular? I have seen the link you have attached and from my point of view, as I see it, it is the Tubular application only with a different name, hence the nature of my question, what features differentiate your application from Tubular and Newpipe?

asandikci commented 3 months ago

@asandikci We'll see, I would like it if we could all just get behind Tubular. It does what y'all want it to, y'all are just unsatisfied with the release pace. Which is understandable when it's something as commonly used as YT. I did my best with my pull requests to follow the same pattern as @polymorphicshade when merging with remote but I'm not 100% sure if it's to spec.

You did the best you could. We are grateful for the improvements and fixes made by the NewPipe Team and polymorphicshade. The only problem for some people here is, as you said, the release pace.

I realize that this is an open source hobby project and he is not responsible for updating it all the time. I can only wish that, but I can't force it. So I exercised my natural right to fork and merge (and the reason I changed the name was to avoid confusion of signatures). Of course, I would like not to deal with all this and continue under this (Tubular) repo.

asandikci commented 3 months ago

Hello again. I'm a daily YouTube (NewPipe/Tubular) user. So I want to build NewPipe + Tubular with my own in a separate repo. if you're impatient like me and want to access the working application now you can visit MaintainTeam/LastPipeBender. This is a Release build (not debug), signed with my keys and includes both tubular/newpipe latest master branches (plus a mini rebranding). Also build is generated with Github Actions CI/CD 😊 Also a PR for merging latest NewPipe hotfix is on the way (see #129). You can wait for it to be merged

May I ask what is the difference between your project and Newpipe and Tubular? I have seen the link you have attached and from my point of view, as I see it, it is the Tubular application only with a different name, hence the nature of my question, what features differentiate your application from Tubular and Newpipe?

@MuerteRoja If applicationID's same and signing keys are different, you could not update app and probably get "app could not be installed" error. Thats why I changed applicationID/Application Name. I also have an idea to merge several newpipe forks for the future. I thought it was a good name for it. The rest of all source code is same with NewPipe/Tubular. I didn't add any other line/feature and won't add any in near future too.

MuerteRoja commented 3 months ago

Hello again. I'm a daily YouTube (NewPipe/Tubular) user. So I want to build NewPipe + Tubular with my own in a separate repo. if you're impatient like me and want to access the working application now you can visit MaintainTeam/LastPipeBender. This is a Release build (not debug), signed with my keys and includes both tubular/newpipe latest master branches (plus a mini rebranding). Also build is generated with Github Actions CI/CD 😊 Also a PR for merging latest NewPipe hotfix is on the way (see #129). You can wait for it to be merged

May I ask what is the difference between your project and Newpipe and Tubular? I have seen the link you have attached and from my point of view, as I see it, it is the Tubular application only with a different name, hence the nature of my question, what features differentiate your application from Tubular and Newpipe?

@MuerteRoja If applicationID's same and signing keys are different, you could not update app and probably get "app could not be installed" error. Thats why I changed applicationID/Application Name. I also have an idea to merge several newpipe forks for the future. I thought it was a good name for it. The rest of all source code is same with NewPipe/Tubular. I didn't add any other line/feature and won't add any in near future too.

I understand, for now I will start using your application to see how it goes, I have imported my Tubular playlist to LastPipeBender without problems, it would be interesting if you could also upload the application to application stores such as F-Droid and Droid-ify so that more people have the possibility to try it.

MuerteRoja commented 3 months ago

Hello again. I'm a daily YouTube (NewPipe/Tubular) user. So I want to build NewPipe + Tubular with my own in a separate repo. if you're impatient like me and want to access the working application now you can visit MaintainTeam/LastPipeBender. This is a Release build (not debug), signed with my keys and includes both tubular/newpipe latest master branches (plus a mini rebranding). Also build is generated with Github Actions CI/CD 😊 Also a PR for merging latest NewPipe hotfix is on the way (see #129). You can wait for it to be merged

May I ask what is the difference between your project and Newpipe and Tubular? I have seen the link you have attached and from my point of view, as I see it, it is the Tubular application only with a different name, hence the nature of my question, what features differentiate your application from Tubular and Newpipe?

@MuerteRoja If applicationID's same and signing keys are different, you could not update app and probably get "app could not be installed" error. Thats why I changed applicationID/Application Name. I also have an idea to merge several newpipe forks for the future. I thought it was a good name for it. The rest of all source code is same with NewPipe/Tubular. I didn't add any other line/feature and won't add any in near future too.

By the way, I'm giving you this warning in good faith, because I have a lot of respect for people like you who want to start their own projects. If your project succeeds, start getting mentally prepared for the typical people who won't stop asking you questions like: "The latest Newpipe update come out, When are you going to update the LastPipeBender app?" This always happens with all projects, and that's why there are developers who can't help but answer in a rude and unfriendly way. Because on a mental/psychological level, this type of question wears you down.

PS: I apologize for my poor English, I'm using a translator to communicate, but well, regardless of how "badly" I've spoken, I guess you've understood the general idea of ​​the context.

njanbobby commented 3 months ago

Hello again. I'm a daily YouTube (NewPipe/Tubular) user. So I want to build NewPipe + Tubular with my own in a separate repo. if you're impatient like me and want to access the working application now you can visit MaintainTeam/LastPipeBender. This is a Release build (not debug), signed with my keys and includes both tubular/newpipe latest master branches (plus a mini rebranding). Also build is generated with Github Actions CI/CD 😊 Also a PR for merging latest NewPipe hotfix is on the way (see #129). You can wait for it to be merged

May I ask what is the difference between your project and Newpipe and Tubular? I have seen the link you have attached and from my point of view, as I see it, it is the Tubular application only with a different name, hence the nature of my question, what features differentiate your application from Tubular and Newpipe?

@MuerteRoja If applicationID's same and signing keys are different, you could not update app and probably get "app could not be installed" error. Thats why I changed applicationID/Application Name. I also have an idea to merge several newpipe forks for the future. I thought it was a good name for it. The rest of all source code is same with NewPipe/Tubular. I didn't add any other line/feature and won't add any in near future too.

By the way, I'm giving you this warning in good faith, because I have a lot of respect for people like you who want to start their own projects. If your project succeeds, start getting mentally prepared for the typical people who won't stop asking you questions like: "The latest Newpipe update come out, When are you going to update the LastPipeBender app?" This always happens with all projects, and that's why there are developers who can't help but answer in a rude and unfriendly way. Because on a mental/psychological level, this type of question wears you down.

PS: I apologize for my poor English, I'm using a translator to communicate, but well, regardless of how "badly" I've spoken, I guess you've understood the general idea of ​​the context.

See, if this release by newpipe was some ui change, or addition of features, people wouldn't have cared waiting for the application being updated. But for the last two releases 0.27.1 and 0.27.2, the application that you can use to watch videos, was not able to do that. Since the core functionality is broken, people (including me) don't have the patience to wait for long. I certainly appreciate polymorphicshade for all his work that he had done, and is currently doing, but when the core functionality is broken, it is understandable that people get impatient.

polymorphicshade commented 3 months ago

Thank you @asandikci. I'm aware of when NewPipe releases a new version.

As usual, I'll get to it when I have a chunk of free time to dedicate.

HueponiK commented 3 months ago

If you decide to make a fork, you are either got what it takes to maintain it, and you commit to it, or your fork dies or get forked itself.

It's fine, that's what's great about it. No one is owed anything.

Mainteners don't owe us anything, and no one owns maintainers not making a fork.

Apple is a great choice for people who wants one strong hand holding everyone and dictating how you should use your device/software.

I'd rather have 3 apks installed than not being able to use it at all or enjoying ads and tracking

lameventanas commented 3 months ago

Since the core functionality is broken, people (including me) don't have the patience to wait for long.

Yes, it's a bit irritating that the core functionality is broken. But what was worse was the response with memes and whatnot instead of just communicating like normal people. Not everyone has the same sense of humor, many people didn't even understand what was going on, and others just thought it was stupid or immature. This time it was totally different.

kaoneko commented 3 months ago

I think @polymorphicshade should use any time they spend on Tubular to solve the known issue of:

every time a sponsor is skipped manually using the "Skip" button, an orphan is sacrificed

This is far more important. Actually, not publishing a build with the upstream fix is the humane thing to do, since as long as y'all can't watch videos with Tubular, the orphans are safe.

I stand with the orphans! ✌🏻

Juan-de-Costa-Rica commented 3 months ago

This does work. Unfortunately because its a new package name, it's appdata is separate, which means that it forks my viewing history etc. I know its just for debugging purposes, but I rely on keeping my watch history. I suppose I'll have to wait for the official, but thank you anyway.

What I've been doing is downloaded the new version of newpipe which is working with YouTube.. then I can check my subscriptions on tubular and if I want to watch something I just hit the share button and share the link from tubular to newpipe. Not ideal, but easy enough until tubular updates!

Sohail-XD commented 3 months ago

No update on izzydroid yet :(

asandikci commented 3 months ago

@Sohail-XD IzzyOnDroid repo is updating with an interval (24H I guess). Just wait a bit more (probably repo will be updated in 3-4 hour) Last updated: 2024-07-27 17:43 UTC

anh0516 commented 3 months ago

It's up!