search

polysemy-research / polysemy-zoo

:monkey::panda_face: Experimental, user-contributed effects and interpreters for polysemy
BSD 3-Clause "New" or "Revised" License
70 stars 20 forks source link

Fixed exports, of member functions and Data.Reflection.Reifies #12

Closed adamConnerSax closed 5 years ago

adamConnerSax commented 5 years ago

Sorry about this. Was preparing to add tests for and re-submit the RandomFu stuff and ran into the fact that I forgot to export some necessary things for making absorbers in other modules using Polysemy.MTL I think that's fixed here. And I've added the labor-saving export of Data.Reflection.Reifies

adamConnerSax commented 5 years ago

Actually. Hold up. A couple more incoming. We should not name the Dict in ReifiableConstraint1 "Dict" because of the collision with Constraints.Dict. So I'l make it Dict1 as it was. And there needs to be an export of the constructor of ConstrainedAction or TH can't use it, which breaks RandomFu. And I think I'll re-export Sub and Dict from constraints to save that dependence for users as well. Working...

adamConnerSax commented 5 years ago

Sigh. There were a couple more. Now I can implement the RandomFu absorber with no additional exports. You can merge this now, or wait until I've added some RandomFu tests to make sure that doesn't catch something else in MTL somehow.

isovector commented 5 years ago

Let me know when this is good to go!

adamConnerSax commented 5 years ago

I think it's good to go. I've got one working test in the RandomFu branch with this version of MTL. So I think this has all the exports we need.
I'm going to add more RandomFu tests before doing a PR for that one.

isovector commented 5 years ago

Thanks!