Updated AbsorbMonadWriter

polysemy-research / polysemy-zoo

:monkey::panda_face: Experimental, user-contributed effects and interpreters for polysemy

BSD 3-Clause "New" or "Revised" License

70 stars 20 forks source link

Updated AbsorbMonadWriter #37

Closed adamConnerSax closed 5 years ago

adamConnerSax commented 5 years ago

updated package.yaml and cabal for polysemy >= v0.7.0.0
re-implemented semPass in terms of Polysemy.Writer.pass instead of Polysemy.Writer.censor
confirmed all tests pass. NB: one failed after this change when the implementation of semPass was still via censor. So the tests are sensitive to the change of semantics.

adamConnerSax commented 5 years ago

Resolves https://github.com/polysemy-research/polysemy-zoo/issues/36

KingoftheHomeless commented 5 years ago

We need to merge this ASAP. polysemy-zoo currently fails to build when you have polysemy-0.7.0.0 due to the package.yaml incorrectly listing version dependencies.

adamConnerSax commented 5 years ago

Huh. That's odd. I didn't have to update anything (except the polysemy bound itself) when I did this PR. Is it just the polysemy bound itself that fails?

KingoftheHomeless commented 5 years ago

I noticed it from Travis failing, but maybe Travis is just incorrectly configured?

KingoftheHomeless commented 5 years ago

That must be it, because the stack.yaml has polysemy-0.5.1.0 as an extra-dep, so it shouldn't use polysemy-0.7.0.0 under normal circumstances. So I'm wrong, there's no hurry. Sorry!

isovector commented 5 years ago

Excellent, thanks!