search

polysemy-research / polysemy-zoo

:monkey::panda_face: Experimental, user-contributed effects and interpreters for polysemy
BSD 3-Clause "New" or "Revised" License
70 stars 20 forks source link

Remove Polysemy.Alias and InterpreterOf #52

Closed KingoftheHomeless closed 5 years ago

KingoftheHomeless commented 5 years ago

With https://github.com/polysemy-research/polysemy/pull/224 merged over at polysemy, Polysemy.Alias and InterpreterOf are now redundant.

There are a few uses of InterpreterOf e r inside polysemy-zoo. These should simply be replaced with Sem (e ': r) a -> Sem r a, as we shouldn't be using InterpreterFor/InterpreterOf internally anyway.

bolt12 commented 5 years ago

Hello,

I could go through the trouble of making this change if that's okay!

KingoftheHomeless commented 5 years ago

Go ahead!

On Thu, 12 Sep 2019, 18:22 Armando Santos, notifications@github.com wrote:

Hello,

I could go through the trouble of making this change if that's okay!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/polysemy-research/polysemy-zoo/issues/52?email_source=notifications&email_token=AGFWW7KW7Y3AQ5ZQHAH3K2TQJJUETA5CNFSM4IUT3IH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6SOSLA#issuecomment-530901292, or mute the thread https://github.com/notifications/unsubscribe-auth/AGFWW7KU3SEC5RQ33NIYGYLQJJUETANCNFSM4IUT3IHQ .

bolt12 commented 5 years ago

Should I remove all the alias that involve InterpreterOf and just make the type explicit?

KingoftheHomeless commented 5 years ago

Yes.

On Thu, 12 Sep 2019, 18:25 Armando Santos, notifications@github.com wrote:

Should I remove all the alias that involve InterpreterOf and just make the type explicit?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/polysemy-research/polysemy-zoo/issues/52?email_source=notifications&email_token=AGFWW7OJ6OEE6HTKP5LA7FTQJJUPTA5CNFSM4IUT3IH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6SO2VY#issuecomment-530902359, or mute the thread https://github.com/notifications/unsubscribe-auth/AGFWW7P5GFBFEKTBQ2C6ILLQJJUPTANCNFSM4IUT3IHQ .

KingoftheHomeless commented 5 years ago

This has been addressed by #53.