https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations not working

ponder-lab / Imperative-DL-Study-Web-App

0 stars 0 forks source link

https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations not working #124

Closed khatchad closed 3 years ago

khatchad commented 3 years ago

Categorizers

Should not be able to access https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations.
But, if their user ID 11, then https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations?user=11 is OK.
https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations?user=12 for example should not be viewable.

Reconcilers and Admins

Can view https://fathomless-inlet-57767.herokuapp.com/ponder/categorizations. Right now, it's an error.

khatchad commented 3 years ago

@mZneit What is your guess on what is wrong here?

mZneit commented 3 years ago

It's a non-existing key in the GET request dictionary. We need to handle the case when no user is specified. And this is when the admin is viewing the categorizations. Almost finishing this. I'll commit the changes by tonight or tomorrow.

mZneit commented 3 years ago

This was fixed here 33e17e6b0241c8615418b7335a2ffed8ba5b8939.

khatchad commented 3 years ago

Looks good. Thanks.