Successfully added categorization that is a func fix without filling any other fields

khatchad commented 3 years ago

I believe that this should be an error.

ID	Sha	Is func fix	Func fix comment	Problem category	Category comment	Problem cause	Cause comment	Problem symptom	Symptom comment	Problem fix	Fix comment	Categorizer	Should discuss	Bug fix	Round
1514	05b6a643d1aa82be3acf8324181595d8abff1eb1	✔	—	—	—	—	—	—	—	—	—	khatchad	✘	—	None

khatchad commented 3 years ago

@tatianacv please upload the fix for this. Also, test thoroughly the combinations possible/valid on this form.

tatianacv commented 3 years ago

I have uploaded the changes in dd01d116c031b3f3632bdb7ad5083d3b20a413d7 and 34af40ae752e88f1dd97f8b9a358730b42397b7b to fix this issue. The test scenarios made:

Scenario # 1: Add fun fix without problem categorizations Expected Behavior: Should not insert Passes
Scenario # 2: Inserting Unknown, Other and Test Expected Behavior: Should not require any problem categorizations (category, symptom, cause, fix) Passes
Scenario # 3: Inserting mixture of new info to database and previous categories, symptoms, etc Expected behavior creates new ones, and lets the user select the one that are already there Passes
Scenario # 4: Inserting a is_func_fix = 0 Expected behavior: leave the form blank and it will insert 0 in func_fix (false) Passes

ponder-lab / Imperative-DL-Study-Web-App

Successfully added categorization that is a func fix without filling any other fields #94