pondersource / sciencemesh-php

Connect your Nextcloud server to Sciencemesh
MIT License
0 stars 1 forks source link

Admin settings dialog for setting iop_url and shared_secret #121

Closed michielbdejong closed 1 year ago

michielbdejong commented 1 year ago

With this, we will not have to rely on sql insert statements anymore.

shokri-navid commented 1 year ago

https://docs.nextcloud.com/server/latest/developer_manual/basics/setting.html

michielbdejong commented 1 year ago

That's for Nextcloud. For ownCloud I found this.

parhamin2010 commented 1 year ago

https://github.com/nextcloud/twofactor_webauthn/ Contribute with Navid to find a sample as new setting dialogue for this integration

parhamin2010 commented 1 year ago

FOUND IT!

michielbdejong commented 1 year ago

The code for this still needs to be pushed and merged on both repos

michielbdejong commented 1 year ago

@navid-dada I discussed with @parhamin2010 just now that Loopback Secret should be read-only but Shared Secret and IP URL should be editable, do you agree?

michielbdejong commented 1 year ago

I heard from Parham that you took a different design decision about this earlier, but it probably wasn't documented anywhere, right?

michielbdejong commented 1 year ago

This was closed automatically by GitHub because it's done for NC Reopening because it's not done for OC

michielbdejong commented 1 year ago

@parhamin2010 copying this here onto the issue (you wrote this in the Google Meet):

doc for new custom configuration: https://doc.owncloud.com/server/next/developer_manual/app/fundamentals/configuration.html

parhamin2010 commented 1 year ago

Instruction for create custom settings in OC: step 1: Add settings section inside appinfo.xml like below `

OCA\APPNAME\Settings\CLASSNAME
<settings-sections>
    <admin>OCA\APPNAME\Sections\CLASSNAME(like last one)</admin>
</settings-sections>`

step 2: Create two directory in lib folder named Sections and another one named Settings with CLASSNAME that you used above.

step 3: Do these steps same for NC but some methods must be replaced based on this article https://docs.nextcloud.com/server/latest/developer_manual/basics/setting.html

michielbdejong commented 1 year ago

Fixed for OC in https://github.com/pondersource/oc-sciencemesh/pull/40

michielbdejong commented 1 year ago

@parhamin2010 can this issue be closed now?

parhamin2010 commented 1 year ago

@parhamin2010 can this issue be closed now?

yes, this one is completed.

michielbdejong commented 1 year ago

Split into pondersource/nc-sciencemesh#240 and pondersource/oc-sciencemesh#47