search

pondersource / sciencemesh-php

Connect your Nextcloud server to Sciencemesh
MIT License
0 stars 1 forks source link

Failure to use usernames containing @, as shareOwner or shareWith #178

Closed mirekys closed 1 year ago

mirekys commented 1 year ago

Hi,

in OC10 (& most probably NC), it is possible to have users with usernames in the e-mail like format: joe@example.org. (we have quite a lot of such users on our production instance)

These users cannot be currently shared with or from using sciencemesh sharing flow.

Their federated sciencemesh id looks like joe@example.org@sciencemesh.cesnet.cz, but the current implementation seems to use example.org part as their sciencemesh site to be contacted, which ultimately fails:

https://github.com/pondersource/oc-sciencemesh/blob/4d924aaf4f3a6be7621c1a52dd98603da9d943c0/lib/Controller/RevaController.php#L232-L299

michielbdejong commented 1 year ago

Thanks for raising this! Should be pretty easy to fix.

MahdiBaghbani commented 1 year ago

fixed in release v0.4.3 https://github.com/pondersource/nc-sciencemesh/pull/360 https://github.com/pondersource/nc-sciencemesh/pull/361.

details in this issue https://github.com/pondersource/nc-sciencemesh/issues/272