Cannot create share through reva-cli in examples/sciencemesh

[michielbdejong]

Steps to reproduce:

• Follow https://github.com/cs3org/reva/tree/sciencemesh-testing/examples/sciencemesh#sciencemesh-development-setup

• Terminal window 1:

  • docker exec -it revanextcloud1.docker bash
  • ./cmd/reva/reva -insecure -host localhost:19000
    • login basic
    • einstein
    • relativity
    • ocm-invite-generate ->

      status:<code:CODE_OK trace:"65df4f0de78d8204add53678bd2de55a" >
      invite_token:<
      token:"cf284531-73f1-471c-813a-dc81ffb31af8"  <---- remember this value!
      user_id:<
      idp:"https://revanextcloud1.docker/"
      opaque_id:"einstein"
      >
      expiration:<
      seconds:1687853903
      >
      >

• Terminal window 2

  • docker exec -it revanextcloud2.docker bash
  • cd /reva
  • git config --global --add safe.directory /reva
  • make reva
  • ./cmd/reva/reva -insecure -host localhost:19000
    • login basic
    • marie
    • radiactivity
    • ocm-invite-forward -idp revanextcloud1.docker -token cf284531-73f1-471c-813a-dc81ffb31af8 <---- value from earlier!

• Terminal window 1, inside revanextcloud1.docker, inside reva-cli, logged in as einstein, continue:

  • mkdir /home/etoa
  • ocm-find-accepted-users
  • ocm-share-create -idp revanc2.docker -grantee marie /home/etoa

    +-----+-------------------------+----------------+----------------------------------------------------------------------------------+-------------------+----------------+------------------+-------------------------------+-------------------------------+
    | #   | OWNER.IDP               | OWNER.OPAQUEID | RESOURCEID                                                                       | TYPE              | GRANTEE.IDP    | GRANTEE.OPAQUEID | CREATED                       | UPDATED                       |
    +-----+-------------------------+----------------+----------------------------------------------------------------------------------+-------------------+----------------+------------------+-------------------------------+-------------------------------+
    | "1" | https://revanextcloud1.docker/ | einstein       | storage_id:"00000000-0000-0000-0000-000000000000" opaque_id:"fileid-/home/etoa"  | GRANTEE_TYPE_USER | revanextcloud2.docker | marie            | 2023-06-26 08:20:01 +0000 UTC | 2023-06-26 08:20:01 +0000 UTC |
    +-----+-------------------------+----------------+----------------------------------------------------------------------------------+-------------------+----------------+------------------+-------------------------------+-------------------------------+

• And:

  • ocm-share-list

    +---+-----------+----------------+------------+----------------------+--------------------+----------------+------------------+-------------------------------+-------------------------------+
    | # | OWNER.IDP | OWNER.OPAQUEID | RESOURCEID | TYPE                 | SHARETYPE          | GRANTEE.IDP    | GRANTEE.OPAQUEID | CREATED                       | UPDATED                       |
    +---+-----------+----------------+------------+----------------------+--------------------+----------------+------------------+-------------------------------+-------------------------------+
    | 1 | unknown   | einstein       | <nil>      | GRANTEE_TYPE_INVALID | SHARE_TYPE_INVALID | revanextcloud2.docker | marie            | 1970-01-01 00:00:00 +0000 UTC | 1970-01-01 00:00:00 +0000 UTC |
    +---+-----------+----------------+------------+----------------------+--------------------+----------------+------------------+-------------------------------+-------------------------------+

• But in terminal window 2, inside revanextcloud2.docker, inside reva-cli, logged in as marie, continue:

  • ocm-share-list-received

    +---+-----------+----------------+---------------+------+-------------+------------------+---------+---------+-------+-----------+
    | # | OWNER.IDP | OWNER.OPAQUEID | REMOTESHAREID | TYPE | GRANTEE.IDP | GRANTEE.OPAQUEID | CREATED | UPDATED | STATE | SHARETYPE |
    +---+-----------+----------------+---------------+------+-------------+------------------+---------+---------+-------+-----------+
    +---+-----------+----------------+---------------+------+-------------+------------------+---------+---------+-------+-----------+

So to einstein@revanextcloud1.docker it looks like the share was sent, but marie@revanextcloud2.docker did not see anything arrive.

[michielbdejong]

In the revanc1.docker logs you see this entry:

2023-06-26 08:20:01.471 DBG ../../workspace/dev-stock/reva/pkg/ocm/client/client.go:200 > Sending OCM /shares POST to https://revanc2.docker/ocm/shares: {"shareWith":"marie@revanc2.docker","name":"etoa","description":"","providerId":"\"1\"","owner":"einstein@revanc1.docker","sender":"einstein@revanc1.docker","ownerDisplayName":"","senderDisplayName":"einstein","shareType":"user","expiration":0,"resourceType":"folder","protocol":{"name":"multi","options":{},"webdav":{"sharedSecret":"76R9BwQH67wSBPBBWW4aCrXU4fIGoLxe","permissions":["read"],"url":"https://revanc1.docker/remote.php/dav/ocm/76R9BwQH67wSBPBBWW4aCrXU4fIGoLxe"}}}

Ah, but in the revanc2.docker logs you see that is probably the culprit:

2023-06-26 08:20:19.929 INF ../../workspace/dev-stock/reva/pkg/ocm/share/repository/nextcloud/nextcloud.go:452 > am.do https://nc2.docker/index.php/apps/sciencemesh/~nobody/api/ocm/GetSentShareByToken {"Spec":{"Token":""}} pid=131 pkg=rgrpc traceid=63890c0d959d48429bda8d8b32931c7c
2023-06-26 08:20:20.018 INF ../../workspace/dev-stock/reva/pkg/ocm/share/repository/nextcloud/nextcloud.go:473 > am.do response 503 <!DOCTYPE html>

We probably didn't implement GetSentShareByToken properly and also that {"Token":""} should never happen, that is a bug on the reva side.

Also, ListReceivedShares is returning an empty array:

2023-06-26 08:35:06.749 INF ../../workspace/dev-stock/reva/pkg/ocm/share/repository/nextcloud/nextcloud.go:452 > am.do https://nc2.docker/index.php/apps/sciencemesh/~marie/api/ocm/ListReceivedShares  pid=131 pkg=rgrpc traceid=8bfae297054131b44d22b18acd99290b
2023-06-26 08:35:06.94 INF ../../workspace/dev-stock/reva/pkg/ocm/share/repository/nextcloud/nextcloud.go:473 > am.do response 200 [] pid=131 pkg=rgrpc traceid=8bfae297054131b44d22b18acd99290b

Despite the fact that the share does exist in maria2.docker:

gitpod /workspace/dev-stock (main) $ ./scripts/maria2.sh 
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Welcome to the MariaDB monitor.  Commands end with ; or \g.
Your MariaDB connection id is 25
Server version: 11.0.2-MariaDB-1:11.0.2+maria~ubu2204 mariadb.org binary distribution

Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others.

Type 'help;' or '\h' for help. Type '\c' to clear the current input statement.

MariaDB [efss]> select * from oc_share_external;
+----+--------+------------+------------------------+-----------+----------------------------------+----------+------+----------+-------+----------------------------------+----------------------------------+----------+
| id | parent | share_type | remote                 | remote_id | share_token                      | password | name | owner    | user  | mountpoint                       | mountpoint_hash                  | accepted |
+----+--------+------------+------------------------+-----------+----------------------------------+----------+------+----------+-------+----------------------------------+----------------------------------+----------+
|  1 |     -1 |          0 | https://revanc1.docker | 1         | 76R9BwQH67wSBPBBWW4aCrXU4fIGoLxe |          | etoa | einstein | marie | {{TemporaryMountPointName#etoa}} | 5dceb6f4d98c0cf731d61d4e7431ac6e |        0 |
+----+--------+------------+------------------------+-----------+----------------------------------+----------+------+----------+-------+----------------------------------+----------------------------------+----------+
1 row in set (0.000 sec)

MariaDB [efss]>

[michielbdejong]

Continued as https://github.com/cs3org/reva/issues/4054