search

poowf / react-native-argon2

MIT License
5 stars 8 forks source link

Merge develop into master #5

Closed zanechua closed 4 years ago

zanechua commented 4 years ago

Changes:

tbrent commented 4 years ago

What are the units of the memory config var? KB? 16 * 1024 = 16 MB? Could be worth a clarification in the readme. The other config vars are relatively obvious, but this one isn't entirely obvious.

zanechua commented 4 years ago

They are in KiB actually. Yeah probably could be added to the README.

tbrent commented 4 years ago

Wouldn't 16 * 1000 be more appropriate as a default, then, representing 16 MiB?

On Tue, Oct 27, 2020 at 1:22 PM Zane Chua notifications@github.com wrote:

They are in KiB actually. Yeah probably could be added to the README.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/poowf/react-native-argon2/pull/5#issuecomment-717516281, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGRGM65WD3VJJ23UMLBFMTSM4TZZANCNFSM4S5XGU6A .

zanechua commented 4 years ago

16 * 1000 represents 16MB not 16MiB.