pop-os / cosmic-applets

WIP applets for cosmic-panel
GNU General Public License v3.0
210 stars 81 forks source link

Icons missing in app tray; user-level desktop files not overriding system-level in app library #667

Open YamiYukiSenpai opened 1 month ago

YamiYukiSenpai commented 1 month ago

image

Cosmic-applets version:

0.1.0~1726494023~24.04~0a32d27

Specific applet that this is regarding (if applicable):

Issue/Bug description: Missing icons on the app tray for my Firefox (Snap) & Rhythmbox (repo).

Strangely, my Firefox Nightly (snap) is fine. image

Though I believe its because there's a user-level desktop file.

Unsure how my Rhythmbox was affected.

Steps to reproduce: Unsure about missing icons. thought it was just my Firefox (Snap), but Rhythmbox was also affected. Could be hit or miss.

As for user-level desktop icons not overriding system-level, just edit an icon in menulibre, or some .desktop editor.

Expected behavior: Icons should be showing up. User-level desktop files and system-level desktop files shouldn't be duplicating.

Other notes: Related to https://github.com/pop-os/cosmic-epoch/issues/996

$ ls -l ~/.local/share/applications/
total 60
lrwxrwxrwx 1 yamiyuki yamiyuki   60 Aug  8 19:38 '*' -> '/home/yamiyuki/snap/steam/common/.local/share/applications/*'
-rwxr-xr-x 1 yamiyuki yamiyuki  170 Feb 24  2022 'Among Us.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  171 Feb 24  2022 'Drawful 2.desktop'
-rw------- 1 yamiyuki yamiyuki 1260 Jun 13  2022  firefox+beta_firefox.desktop
-rwxr-xr-x 1 yamiyuki yamiyuki 9636 Jun 13  2022  firefox+edge_firefox.desktop
-rw-r--r-- 1 yamiyuki yamiyuki    0 Feb 24  2022  mimeapps.list
-rwxr-xr-x 1 yamiyuki yamiyuki  199 Feb 24  2022 'STAR WARS The Force Unleashed II.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  218 Feb 24  2022 'STAR WARS The Force Unleashed Ultimate Sith Edition.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  186 Feb 24  2022 'The Jackbox Party Pack 2.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  186 Feb 24  2022 'The Jackbox Party Pack 3.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  186 Feb 24  2022 'The Jackbox Party Pack 4.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  186 Feb 24  2022 'The Jackbox Party Pack 5.desktop'
-rwxrwxr-x 1 yamiyuki yamiyuki  188 Jul 11  2022 'The Jackbox Party Pack 7.desktop'
-rwxr-xr-x 1 yamiyuki yamiyuki  184 Feb 24  2022 'The Jackbox Party Pack.desktop'

menulibre doesn't work with Cosmic as of right now. This was most likely generated when my laptop was still on Kubuntu 23.10 as I'm re-using the profile.

joshuamegnauth54 commented 1 day ago

Hi! The issue where user desktop files aren't overriding system files for the app library is better suited for this repository. You can open an issue there and tag me because I recently worked on a similar fix for the launcher so I may be able to fix this one too.

(I may forget so you can tag me).