pop-os / iso

Pop!_OS ISO production
Other
500 stars 65 forks source link

Don't leak build environment env vars, or include .lanchpadlib #271

Closed ids1024 closed 3 years ago

ids1024 commented 3 years ago

This should fix https://github.com/pop-os/iso/issues/269, though it will have to be tested on Jenkins to verify.

Looking at the files in .launchpadlib from the ISO, it looks like this was probably added by add-apt-repository, which uses launchpadlib to get the display name of a PPA.

Testing locally, I didn't end up with an extra home directory before this. But presumably it's some env var that's responsible for leaking the username jenkins, so clearing the env should prevent that. This should also generally prevent env vars for leaking and make builds more reproducible across systems.

In my local testing, the second commit prevents the filesystem from having a .lanchpadlib directory anywhere.