search

pop-os / iso

Pop!_OS ISO production
Other
499 stars 65 forks source link

Include `pop-hp-vendor` in pool on 22.04 #299

Closed ids1024 closed 2 years ago

jackpot51 commented 2 years ago

All its friends have to be included too:

jackpot51 commented 2 years ago

The best way to test the pool for completeness is to build the ISO locally, run it in a VM, disable networking, then attempt to install pop-hp-vendor. If it complains about missing packages, those have to be added to the pool. You can quickly edit the pool by running make clean-pool

ids1024 commented 2 years ago

Ah, adding a package to this list doesn't also add depends and recommends? Then yeah, a couple other things are needed.

jackpot51 commented 2 years ago

Exactly, here we have to build the full list of packages that are needed.

ids1024 commented 2 years ago

Had trouble building the ISO, but I got it working with make GPG_NAME=.... Seems to have everything it needs now.

jackpot51 commented 2 years ago

I'm just gonna merge, I'm not sure what QA is really possible without building an ISO from this and then adding the distinst PR.

leviport commented 2 years ago

I was building one locally, but yeah that's probably way faster.