Closed ningvin closed 2 years ago
I didn't know the launcher used to do this. Very useful. Thank you for fixing it!
Also, to answer your question you can link issued in other repos like this:
/#<issue/pr number> and git will auto-generate the link. pop-os/shell#1278
-> pop-os/shell#1278
Glad I could help and thanks for the info :)
This addresses an issue opened in the pop-os/shell repo (is there a more convenient way to link to issues of a different project...?), where the ability to close an item in the launcher window via
Ctrl
+Q
was lost, presumably after replacing the JS service with the Rust service.The request handler for the Quit event of the pop_shell plugin just did nothing, instead of calling the
WindowQuit
function via D-Bus.I am assuming this is just an oversight and there are no technical limitations preventing this (it seemed to work just fine when I tested it locally), hence this pull request :-)