pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
228 stars 45 forks source link

Fixed web plugin favicons, binary size reduction, perf optimizations #97

Closed mmstick closed 2 years ago

mmstick commented 2 years ago

Binary size should now be reduced from ~8MB to ~6MB, which is shared memory to all plugins.

Closes #98

jacobgkau commented 2 years ago

This fixes favicon caching for Amazon and Crates.io. However, it breaks the icon for Flathub.

Screenshot from 2022-03-29 11-07-00

Interestingly, the DEV icon has changed. Before, it used the same favicon that Firefox recognizes:

Screenshot from 2022-03-29 11-08-53

After, it's different:

Screenshot from 2022-03-29 11-07-03

mmstick commented 2 years ago

Seems to be the icon they're using here: https://dev.to/favicon.ico

jacobgkau commented 2 years ago

Seems to be the icon they're using here: https://dev.to/favicon.ico

They have their shortcut icon set to a favicon.ico on a different domain:

image

jackpot51 commented 2 years ago

I do not recommend this. I have noticed reqwest has better performance than ureq.

mmstick commented 2 years ago

I've reverted the change to keep reqwest

jacobgkau commented 2 years ago

Amazon and Crates.io are showing the Google API's default favicon instead of their own icons again on 09d126e.

mmstick commented 2 years ago

Seems the correct order would be first scraping the page for the favicon path, then checking the root path, and falling back on Google as a last resort.

jacobgkau commented 2 years ago

On ca4eec7, the lib.rs and ArXiv icons don't load:

Screenshot from 2022-03-30 09-23-17

Screenshot from 2022-03-30 09-25-36

The dev icon doesn't load, and doesn't show a placeholder space either, and it shows a backtrace:

Screenshot from 2022-03-30 09-23-50