search

pop-os / xdg-desktop-portal-cosmic

GNU General Public License v3.0
43 stars 37 forks source link

screenshot: indicate correct version #103

Closed FineFindus closed 1 week ago

FineFindus commented 1 month ago

Return version 1 for the screenshot portal to indicate that the PickColor method is not yet fully supported. This will allow clients to properly check and handle the missing method.

Ref: https://github.com/flatpak/xdg-desktop-portal/pull/766

ids1024 commented 3 weeks ago

This shouldn't actually impact behavior, because the version property isn't defined properly (here or before). It needs #[zbus(property, name = "version")] to use the right name, instead of the name Version.

https://github.com/pop-os/xdg-desktop-portal-cosmic/pull/96 has a commit changing that, though it still needs some other changes (I guess including implementing PickColor).

FineFindus commented 3 weeks ago

Thanks! I've updated the commit.