portapack-mayhem / mayhem-firmware

Custom firmware for the HackRF+PortaPack H1/H2
GNU General Public License v3.0
3.3k stars 540 forks source link

[Wiki Issue] Wiki is using grabify link to track users #2137

Closed Programicus closed 4 months ago

Programicus commented 5 months ago

Describe the bug.

Currently, the H2 mayhem edition on the portapack versions page uses a grabify link to redirect to alibaba. This was introduced in commit ddb6ab2e16c331ca744fab018087849c671be958 to the wiki.

For context, grabify is a url shortener (similar to bit.ly), however it also comes with a page that logs all uses of the redirection. Here is an example such a tracking and logs page for a redirect I made to github.com, as well as a hit it via archive.ph to give an example hit without doxing myself. As you can see from this example, I get quite a bit of information about people who the link: ip address, timezone, browser info, isp, os version, etc.

Reproduction

Go to: H2 mayhem edition on the portapack versions page. Hover over the link and see that it https://grabify.link/5CL1IP.

Expected behavior

Have either a normal alibaba link, or one from a reputable url shortner like bit.ly or t.ly

Environment/versions

No response

Anything else?

Sorry if this isn't the best way to post this. I couldn't find a way to create an issue about the wiki page

eried commented 4 months ago

Hi! Grabify is made by one of our contributors, I actually prefer this redirection than other option knowing we can discuss directly about it.

What is your concern? this redirection does not get more info that any script can get from your browser, there is no "magic" spyware or something evil behind. We ofc get click stats about what users are interested on.

eried commented 4 months ago

I added a note on the wiki. It needs more work, but it is open for edits

Programicus commented 4 months ago

Fair enough that you are just using it for click stats, and makes sense knowing that grabify was made by one of the contributers.

I'm used to it seeing grabify used to with respect to scamming and scam baiting, so and had associate it with a lack of trust in the clicker. You're right in that it doesn't give you anything extra than if you were hosting your the link shortener on a server you controlled.

vorpalhex commented 1 month ago

This grabify link is broken under Pihole and most forms of adblock since grabify is used for scams and phishing so often. I can't even follow the links because of this.

eried commented 1 month ago

This grabify link is broken under Pihole and most forms of adblock since grabify is used for scams and phishing so often. I can't even follow the links because of this.

As we explained, grabify can be consider an "in-house" product, so for the moment there is no plans of removing it. We know there is a small amount of people that get bothered by it, im sorry about that.

Option: whitelist it in pihole and report it as a wrong url to filter, since it is just coincidental that was used for phishing 😃

vorpalhex commented 1 month ago

If your goal is to have as many people use your affiliate link as possible, then just expand the affiliate link. Right now most people are going to click it, discover it's "broken" and then leave.

Whereas if you just have the whole aliexpress link with the aff_id in it.. it'll actually still work under pihole/adguard/etc. Afaik the only situation where the link would get stripped is a right click "copy clean link" under Brave.

eried commented 1 month ago

Good but as I explained, for the moment is no plans of removing the redirection

BeanBagKing commented 1 month ago

The in house comments don't really play into this for me. It's not in house for me, it's in house for you, and no offense, but I don't know you. Not to reiterate a point too many times, but these kind of trackers are usually associated with scammy behavior. I don't like bit.ly or any of the other shorten either, but at least those can be used with URL expanders.

More importantly, it takes something pretty significant for me to go whitelist something in my pihole. It doesn't interfere with the majority of sites, and when it does I'm typically more motivated to move on than unblock it. It's been added to one of the lists for a reason, so why would I go and exclude it?

eried commented 1 month ago

Adding it to the whitelist was only suggested if you want to click our links. Until we decide to stop using grabify, it's the only way to decode its secrets 😁