porter-finance / v1-core

⛰️ Smart contracts powering the Porter protocol.
https://porter.finance
GNU Affero General Public License v3.0
4 stars 3 forks source link

consider reentrancy guard usage #275

Closed Namaskar-1F64F closed 2 years ago

Namaskar-1F64F commented 2 years ago

https://github.com/spearbit-audits/porter/pull/1/files/9cb5b8ed8d6ba0d95cc4ed8528d23aebbb740890#r863259144

RusseII commented 2 years ago

I'm leaning towards adding it as an abundance of caution. I think the only time it'd be an issue though is if we accidentally allow a 777 token in the future. So it'd do nothing in the present but it'd basically be an additional safeguard if there is a problem upstream