search

portfolio-performance / portfolio

Track and evaluate the performance of your investment portfolio across stocks, cryptocurrencies, and other assets.
http://www.portfolio-performance.info
Eclipse Public License 1.0
2.88k stars 593 forks source link

sell of imported PDF not editable #2005

Open christen90 opened 3 years ago

christen90 commented 3 years ago

Describe the bug In VL-FondsDepos from ebase there is no reference account. Taxes and fees are applied via a SALE of shares. The resulting amount is 0. I'm not able to save it as a SALE action. However the PDF importer manages to create such bookings.

To Reproduce Steps to reproduce the behavior:

  1. Import Data from _ebaseauszug06.txt test case #2004
  2. Buchung editieren (Verkauf)
  3. as long as Gutschrift = 0 - item is not saveable

Expected behavior imported items are editable

Screenshots image

Desktop (please complete the following information):

Solution Ideas

zr40 commented 3 years ago

GUI: accept 0 as amount if TAX or FEE is filled

Or rather, always accept 0. This would help with removing expired option positions.

chirlu commented 3 years ago

That’s an importer bug, I’d say.

@zr40: You can (and should) use “outbound delivery”.

zr40 commented 3 years ago

Outbound delivery suffers from the same problem. It doesn't accept 0. And positive values are seen as withdrawals, which is not appropriate here.

chirlu commented 3 years ago

Outbound delivery suffers from the same problem. It doesn't accept 0.

You haven’t actually tried it, have you?

zr40 commented 3 years ago

I actually have tried. It says "Input required for 'Sub-Total'" and the Save button is disabled.

Screenshot from 2021-01-25 15-24-08

chirlu commented 3 years ago

Oh, that’s interesting, because it is meant to work and it does work for me.

After some experiments, it seems that the (blocking) error only appears if you enter 0 into the subtotal field directly. If, instead, you enter 0 into either of “Quote” or “Value of outbound delivery”, the subtotal will be calculated as 0, and the error isn’t raised. That’s a bug.

christen90 commented 3 years ago

With outbound delivery it can be done: image

Which booking type is more applicable for Vermögenswirksame Leistungen? This specific booking does not contain a reference account. I fear, that an outbound booking is better suited and the importer has to be changed... Also the purchase of VL-FondsDepot could fit better into INBOUND_DELIVERY. Maybe it's better to make a difference between normal depot and VL-FondsDepot and split the importer into 2.

Anyway it should not be possible, that the importer is able to create bookings which can not be replicated by using the gui.

zr40 commented 3 years ago

Oh, that’s interesting, because it is meant to work and it does work for me.

After some experiments, it seems that the (blocking) error only appears if you enter 0 into the subtotal field directly. If, instead, you enter 0 into either of “Quote” or “Value of outbound delivery”, the subtotal will be calculated as 0, and the error isn’t raised. That’s a bug.

Indeed, it works for outbound delivery. Thanks! For inbound delivery however I can't get it to accept 0.

chirlu commented 3 years ago

For inbound delivery however I can't get it to accept 0.

Yes, that’s correct. It doesn’t make sense as it would, e.g., mean infinite performance.

zr40 commented 3 years ago

Not for my use case, which is to close a written option position that has expired.

Even if it would look strange to you from an individual position point of view, it would be correct from a whole portfolio point of view.