search

poseidon-framework / poseidon-hs

A toolset to work with modular genotype databases in the Poseidon format
https://poseidon-framework.github.io/#/trident
MIT License
7 stars 2 forks source link

Fix .janno decoding issues #313

Closed nevrome closed 3 weeks ago

nevrome commented 1 month ago

The bug described in #312 should be fixed. But I also want to see if we can remove removeNoBreakSpace. I'll write a test later to check.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.88%. Comparing base (6d6e8f3) to head (079f0ea). Report is 11 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #313 +/- ## ======================================= Coverage 59.88% 59.88% ======================================= Files 29 29 Lines 4170 4166 -4 Branches 481 480 -1 ======================================= - Hits 2497 2495 -2 + Misses 1192 1191 -1 + Partials 481 480 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nevrome commented 4 weeks ago

If merged this solves #312.

I indeed found we can now remove removeNoBreakSpace. I love removing code.