search

poseidon-framework / poseidon-hs

A toolset to work with modular genotype databases in the Poseidon format
https://poseidon-framework.github.io/#/trident
MIT License
7 stars 2 forks source link

Fix `parseInGenoSep` #322

Closed nevrome closed 5 days ago

nevrome commented 1 week ago

Ui - parseInGenoSep has two bugs (I think): It removes needed file extensions (#321) and it reads PLINK data as GenotypeEigenstrat.

This is not a testament to good quality control... I really think we made a mistake with the way we set up our golden tests without the actual optparse-applicative interface.

Please check thoroughly to make sure we get it right now!

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.29%. Comparing base (682f6ba) to head (f7a139c). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Poseidon/CLI/OptparseApplicativeParsers.hs 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #322 +/- ## ========================================== + Coverage 59.99% 60.29% +0.30% ========================================== Files 29 29 Lines 4179 4181 +2 Branches 481 491 +10 ========================================== + Hits 2507 2521 +14 + Misses 1191 1169 -22 - Partials 481 491 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: