posit-dev / air

21 stars 0 forks source link

LSP warnings on nightly rust #70

Open DavisVaughan opened 2 days ago

DavisVaughan commented 2 days ago
warning: creating a mutable reference to mutable static is discouraged
   --> crates/lsp/src/main_loop.rs:382:32
    |
382 |             if let Some(val) = AUXILIARY_EVENT_TX.get_mut() {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-[20](https://github.com/posit-dev/air/actions/runs/12042018483/job/33574940228?pr=69#step:9:21)24/static-mut-references.html>
    = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives
    = note: `#[warn(static_mut_refs)]` on by default

warning: creating a shared reference to mutable static is discouraged
   --> crates/lsp/src/main_loop.rs:387:17
    |
387 |                 AUXILIARY_EVENT_TX.set(auxiliary_event_tx).unwrap();
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-20[24](https://github.com/posit-dev/air/actions/runs/12042018483/job/33574940228?pr=69#step:9:25)/static-mut-references.html>
    = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives

warning: creating a shared reference to mutable static is discouraged
   --> crates/lsp/src/main_loop.rs:457:14
    |
457 |     unsafe { AUXILIARY_EVENT_TX.get().unwrap() }
    |              ^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
    |
    = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
    = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives