Add package information in completions

posit-dev / ark

Ark, an R kernel

MIT License

179 stars 15 forks source link

Add package information in completions #616

Closed lionel- closed 3 weeks ago

lionel- commented 4 weeks ago

Addresses https://github.com/posit-dev/positron/issues/5225

Positron Release Notes

New Features

Completions for R functions and objects now display which package they are from (posit-dev/positron#5225). And completions for package namespaces are now indicated by a :: suffix to make it clearer what is being completed.

Bug Fixes

DavisVaughan commented 4 weeks ago

I think we also need to let the client know we support this https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_completion

Look for labelDetailsSupport there.

It's possible we could be working with a client that doesn't support this, but it is >3 years old now so its probably ok to ignore the client supplied option for now (we should still set the server side one though)

lionel- commented 3 weeks ago

Another change I've made is to add :: as label details for namespace completions.

Before:

After:

The goal is to make it clearer that a namespace is being completed and :: will be inserted.