search

posit-dev / positron

Positron, a next-generation data science IDE
https://positron.posit.co
Other
2.82k stars 91 forks source link

Implement summary statistics and sparklines for duckdb data explorer backend #5128

Open wesm opened 1 month ago

wesm commented 1 month ago

Provide feature parity for duckdb data explorer backend

testlabauto commented 20 hours ago

@dfalbel believes that the difference between the tailnum representations show here: Image (left is code open, right is duckdb) is wrong on the duckdb side: "duckdb is failing to report the 'others count'"

jonvanausdeln commented 20 hours ago

I also noticed that it can now get into a bad state..

  1. Open flights.parquet
  2. Observe it opens fine & close it
  3. Open 100x100.parquet
  4. Note that it just gives a blank data explorer tab
  5. Go back and try to open flights.parquet again (or any other file that previously it could show)

The only way to get out of this is to reload the positron window or restart positron.

@wesm , if you think this is a separate, unrelated issue, just let me know and I will open up a separate issue.

wesm commented 16 hours ago

Thanks —- looks like the QA dataset has some edge cases that will need some special treatment. I will work on this today.

On the frequency table: I did not initially compute the “other” count since it isn’t required by the protocol, but I will add it.

I’ll put this issue back in In Progress and revert back when it’s ready to verify again.

wesm commented 9 hours ago

I merged the fixes -- moved this back into verification