search

positron-solutions / transient-showcase

Example forms for transient UI's in Emacs
GNU General Public License v3.0
213 stars 22 forks source link

fix link description for transient-switch match lin #18

Closed nverno closed 1 year ago

nverno commented 1 year ago

Simple typo fix for transient-switch link description

psionic-k commented 1 year ago

Not sure what's ambiguous here. The preceding line mentions both switch and option. Anyway the change makes the line inconsistent.

nverno commented 1 year ago

the link description says transient-option but the link is to transient-switch...

psionic-k commented 1 year ago

It's two different links. The change makes it inconsistent.

nverno commented 1 year ago

I just changed the link description of the second link to match it's target - transient-switch.

Before change it looks like (both links have same description) before And after it looks like after

I thought that was what you intended there

psionic-k commented 1 year ago

Red green colorblind. LGTM

psionic-k commented 1 year ago

I'll fix up this stupid sign-off check. I think it results from local git config not matching your github config, but as long as the email addresses match, I consider it valid.

sign-off not found for commit author: nverno noah.v.peart@gmail.com; found: ['Noah Peart <noah.v.peart@gmail.com>']

Probably switching the bot back. Anyway, this will get merged with attribution intact.

nverno commented 1 year ago

Thanks, sorry about the confusion :/. I fixed the sign-off