Correction of the work with comments and general improvements

postcss / postcss-nested

PostCSS plugin to unwrap nested rules like how Sass does it.

MIT License

1.17k stars 65 forks source link

Closed Ulyanov-programmer closed 1 month ago

Ulyanov-programmer commented 1 month ago

List of changes:

Fixed a bug where rules with comments without properties could lose comments embedded in them.
The code that was duplicated several times was deleted and moved to a new function.
General code improvements: foreach has been replaced with for, and some methods have been optimized.

All tests were passed correctly.

Ulyanov-programmer commented 1 month ago

Well, or something like that. I didn't seem to miss anything.

Ulyanov-programmer commented 1 month ago

It's a pity that he complains about the operator ?. . I thought he worked everywhere. If it's critical, I'll replace it.

ai commented 1 month ago

Hm, it may be an ESLint issue since we should support >=18

ai commented 1 month ago

I will look

ai commented 1 month ago

I removed Node.js 12-16 support from main. No need to rebase.

Ulyanov-programmer commented 1 month ago

Haven't heard from you for a long time, have you been waiting for me to add a test?

ai commented 1 month ago

Haven't heard from you for a long time, have you been waiting for me to add a test?

Yes

Ulyanov-programmer commented 1 month ago

Haven't heard from you for a long time, have you been waiting for me to add a test?

Yes

No comment, it's fabulous.

ai commented 1 month ago

Thanks. Released in 7.0.