Upgarde Restsharp to fix failing tests

postmanlabs / postman-code-generators

Common repository for all code generators shipped with Postman

Apache License 2.0

996 stars 351 forks source link

Upgarde Restsharp to fix failing tests #745

Closed aman-v-singh closed 6 months ago

aman-v-singh commented 6 months ago

Using Restsharp version 111.0.0 to fix failing tests.
Client option MaxTimeout renamed to Timeout and changed type to Timespan

VShingala commented 6 months ago

@aman-v-singh Not all users should have started using v11 of restsharp. Older users may still want the older behaviour of having MaxTimeout. In such cases, we should ideally introduce an option to configure the behaviour rather then enforcing new version to everyone. wdyt?

aman-v-singh commented 6 months ago

@VShingala Makes sense. This issue happened because we did not specify the RestSharp version, so it used the latest version and did not support MaxTimeout. I have used the version (v110.0.0) that supports our code, and the tests are passing.