guruofquality
commented
9 years ago What's even worse is that I'm the moron that came up with the gr-uhd names as well... So, I don't want to pull the rug out under anyone's feed here. But you are right that it might be better. Also the other toolkit blocks are using these rate and freq labels as well to automatically set their axis (see plotters).
I have found that a lot of generic blocks that use labels, often need a name passed as a parameter, because the upstream block providing the label may be one of many things (including but not limited to sdr source). So the actual label ID is not so important in this case, just as long as any two blocks agree.
Then there are blocks that specifically are meant to be connected to the SDR source/sink blocks. I think my concern is that some of the gnuradio blocks may have these tag names hard-coded, and pothos sdr label names would prevent them from being used.
So I am also considering:
- Adding functions to set the used label id's (just like many of the other blocks have)
- Or a function to configure "gnuradio" compatible labels. If there are blocks out there that need this. Obviously the first option is a little more flexible.
I propose that the label names be changed so as to match tag names found in gnuradio, so that someday some compatible behavior or even standard may evolve.
The following tag names are used in gr-uhd and gr-osmosdr/bladerf:
txTime -> tx_time txEnd -> tx_eob rxTime -> rx_time rxEnd -> rx_eob rxFreq -> rx_freq rxRate -> rx_rate