Closed zuckschwerdt closed 2 months ago
@guruofquality is it okay if I touch up the cmake build like this, possibly in other modules as well?
I might later add a Github Action to check PRs and report build warnings to contributors.
@guruofquality is it okay if I touch up the cmake build like this, possibly in other modules as well?
I might later add a Github Action to check PRs and report build warnings to contributors.
oh totally, that sounds great :100:
This fixes the cmake warning about mismatched case in package search, proper case should be
LibAIRSPY
.Also uses
REQUIRED
onfind_package(LibAIRSPY)
to get explicit error messages instead of failing implicitly later on.(Note the mention of
LibAIRSPY_LIBRARIES
andLibAIRSPY_INCLUDE_DIRS
, case does matter for e.g. build scripts.)Adds Clang compatibility for compiler options. Bumps to a minimum of cmake 2.8.12 (Oct 2013) so we can use
add_compile_options
to proper order-Wall -Wextra
vs-Wno-unused-parameter
whichadd_definitions
won't do. This gets rid of all thewarning: unused parameter 'foo' [-Wunused-parameter]