search

potsky / laravel-localization-helpers

🎌 Artisan commands to generate and update lang files automatically
GNU General Public License v3.0
187 stars 38 forks source link

Laravel 5.6 compatibility #70

Open limenet opened 6 years ago

limenet commented 6 years ago

Laravel 5.6 is out and it doesn't seem like much has changed: https://laravel.com/docs/5.6/upgrade except PHP >= 7.1.3 being required which results in the build on PHP 7.0 to fail.

It'd be great if this package supported Laravel 5.6!

I'm not sure against which branch I should send the PR to adhere to your versioning scheme: https://github.com/potsky/laravel-localization-helpers#1-installation

Let me know if you'd like me to make any changes!

Also, please see https://github.com/potsky/laravel-localization-helpers/pull/69#issuecomment-366932548 for why I upgraded satooshi/php-coveralls.

limenet commented 6 years ago

Now all tests are passing except the ones using Microsoft's Translator Service: Please provide a client_key for Microsoft Translator service.

imbrish commented 6 years ago

Any plans on merging this?

ldanielduarte commented 6 years ago

Hello, @limenet any news on this? @potsky can you help solving the tests? Thank you!

potsky commented 6 years ago

Hi ! creating a new company, hiring, fund raising... no more time to check the PR, create new branches for new laravel versions, etc...

Does anyone want to be a collaborator on the repository to manage it

ldanielduarte commented 6 years ago

@limenet you are already involved. Go for it! :muscle: