search

pottermm / javachromiumembedded

Automatically exported from code.google.com/p/javachromiumembedded
0 stars 0 forks source link

Reorganize all java classes within a package structure. #54

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This issue is an enhancement of JCEF (patch 10 of 10) 
----------------------------------------------------
Purpose: Reorganize all java classes within a package structure.

This patch relies on the attached patch file of issue #53. 
If you want to try these code changes, add the patch of issue #53 first and 
afterwards add the patch file attached to this issue. Otherwise you'll get some 
patch-errors.

Due the last 9 patches have added several classes and changed existing code,
this patch only reorganizes the classes in the following java packages:

package org.cef
- CefApp
- CefClient
- OS

package org.cef.browser
- CefBrowser
- CefBrowserFactory
- CefBrowserOsr
- CefBrowserWindow
- CefBrowserWr
- CefBrowser_N
- CefRenderer

package org.cef.handler
- CefAppHandler
- CefAppHandlerAdapter
- CefClientHandler
- CefCommandLine
- CefCommandLine_N
- CefDisplayHandler
- CefDisplayHandlerAdapter
- CefFocusHandler
- CefFocusHandlerAdapter
- CefLifeSpanHandler
- CefLifeSpanHandlerAdapter
- CefLoadHandler
- CefLoadHandlerAdapter
- CefMessageRouterHandler
- CefMessageRouterHandlerAdapter
- CefNative
- CefQueryCallback
- CefQueryCallback_N
- CefRenderHandler
- CefRenderHandlerAdapter

package org.cef.browser.mac
- CefBrowserWindowMac

package tests
- MainFrame

Please see attached patch file for further informations.

Original issue reported on code.google.com by k...@censhare.de on 8 Mar 2014 at 8:12

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi,
Is it possible for you to host your version(zip or git) of Jcef.
It will be easy to download and play with.

Regards,

Original comment by kscr...@gmail.com on 10 Mar 2014 at 10:38

GoogleCodeExporter commented 9 years ago 
Hi,
my changes aren't within a public reachable svn. But you can do the following 
to play around with the sources:
(1) Download patches from issue 45 up to issue 54 e.g. to "/my/patches/"
(2) check out revision 31 e.g. into directory "jcef-playground": 
svn co -r31 http://javachromiumembedded.googlecode.com/svn/trunk/ 
jcef-playground
(3) Go into the directory "jcef-playground" (or however you've named it)
(4) apply one patch after another (starting with issue 45):
svn patch /my/patches/01_2014-03-03_issue_XX_NPE_while_searching_lib_path.patch
svn patch 
/my/patches/02_2014-03-03_issue_XX_splited_CefClientDelegate_into_several_handle
rs.patch
svn patch 
/my/patches/03a_2014-03-03_issue_XX_renamed_CefHandler_to_CefClientHandler.patch
svn patch 
/my/patches/03b_2014-03-06_issue_XX_splited_CefClientHandler_into_several_handle
rs.patch
svn patch /my/patches/04_2014-03-05_issue_XX_added_CefLoadHandler.patch
svn patch 
/my/patches/05_2014-03-05_issue_XX_added_additional_methods_to_CefDisplayHandler
.patch
svn patch 
/my/patches/06_2014-03-05_issue_XX_added_additional_methods_to_CefLifeSpanHandle
r.patch
svn patch 
/my/patches/07_2014-03-06_issue_XX_added_additional_methods_to_CefBrowser.patch
svn patch /my/patches/08a_2014-03-06_issue_XX_renamed_CefContext_to_CefApp.patch
svn patch 
/my/patches/08b_2014-03-06_issue_XX_added_CefAppHandler_and_CefCommandLine_to_ja
va.patch
svn patch 
/my/patches/09_2014-03-07_issue_XX_introduced_multiple_CefClients_with_multiple_
CefBrowsers.patch
svn patch /my/patches/10_2014-03-07_issue_XX_organized_java_into_packages.patch
(5) Stop on any step you want and test the changes. You can use the MainFrame 
application for testing the changes.

Cheers,

Original comment by k...@censhare.de on 12 Mar 2014 at 6:34

GoogleCodeExporter commented 9 years ago 
Btw,

if you're interested in, please have a look at this document with the "overall" 
plan I've discussed with Marshall Greenblatt:
https://docs.google.com/document/d/1CFihrGcU504yv2Xogt3Pll9L2b9E8MVYmwpQlCT17Do/
edit?usp=sharing

and this one with the (currently) assigned changes for step1 (issue 45 - issue 
54):
https://docs.google.com/document/d/1NcrgjCugOpYFvb-HtVsP5xrVYsvEtda7uPhn_bPdRsY/
edit?usp=sharing

Cheers,
Kai

Original comment by k...@censhare.de on 12 Mar 2014 at 6:38

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 12 Mar 2014 at 9:50

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 12 Mar 2014 at 9:53

GoogleCodeExporter commented 9 years ago 
Thank you.
Just downloaded the patches and ran the test app on linux64.

The browser frame jerks whenever I mouse over to elements..
google icon, search box etc. 

an info message appears on the console: 
"Info: GLDrawableHelper.reshape: pre-exisiting GL error 0x501".

Any solution ?

Original comment by kscr...@gmail.com on 19 Mar 2014 at 8:31

GoogleCodeExporter commented 9 years ago 
Hi kscr…,
I didn't had a chance to test my changes on Linux, yet.

Only a suggestion:
I've changed the handling of the message loop from 33ms timer-based 
"doMessageLoopWork()" to blocking "runMessageLoop()". So what you describe 
could be a problem with the speed of the message loop handling.

So please add the attached patch file to your local checkout (after the other 
patches from issues 45 to 54) and please test if this helps you.

Please keep me informed about your test-result.

Cheers,
Kai

Original comment by k...@censhare.de on 21 Mar 2014 at 2:04

Attachments:

GoogleCodeExporter commented 9 years ago 
Kai,
Thank you for the patch.
But the flickering still exists. :(

The flickering occurs only when the mouse is moved over html document.

I am going to apply later patches.

Regards,
Chandra

Original comment by kscr...@gmail.com on 26 Mar 2014 at 4:01

GoogleCodeExporter commented 9 years ago 
Hi Chandra,
while I'm currently doing some tests on windows, I've recognized the same 
behavior as you're describing (jerking frame) and I've found the cause for that.

The display jerks every time, if the status-bar (at the bottom) increases its 
height due the text doesn't fit into the info-bar.

So, please try the attached patch file. This is a simple work-around for this 
problem.

Regards,
Kai

Original comment by k...@censhare.de on 31 Mar 2014 at 2:26

Attachments:

GoogleCodeExporter commented 9 years ago 
Attached you'll find an updated version of the patch file. This patch relies on 
svn revision r40. 
The "jerking frame"-Bug is fixed within this update.

Original comment by k...@censhare.de on 17 Apr 2014 at 7:37

Attachments:

GoogleCodeExporter commented 9 years ago 
Added in revision 41 with some fixes to tools scripts.

Original comment by magreenb...@gmail.com on 28 Apr 2014 at 5:07