powdr-labs / powdr

A modular stack for zkVMs, with a focus on productivity, security and performance.
Apache License 2.0
416 stars 82 forks source link

Simplify Bus Interaction #2047

Closed georgwiese closed 2 weeks ago

georgwiese commented 3 weeks ago

Fixes #1823

This PR cleans up our bus_interaction function and all functions that depend on it, so that columns and challenges are added when needed, instead of being passed by the caller.

I also changed the tests a bit: I removed test_data/std/bus_{permutation,lookup}_via_challenges{_ext?}.asm and instead added more realistic tests:

georgwiese commented 2 weeks ago

Rebased onto main and pushed 32f40d0b8606dfedbb005b94a7b64d25be72d48d, which I forgot to push earlier.