pp-mo / ncdata

Free and efficient exchange of data between netcdf files, Xarray and Iris
https://ncdata.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
10 stars 2 forks source link

Fix unlimited dimensions in Iris conversion #43

Open pp-mo opened 10 months ago

pp-mo commented 10 months ago

We seem to have a problem with ncdata.dataset_like if we try to save with unlimited dimensions. Example test code (fails) : https://github.com/pp-mo/ncdata/blob/9f8de90a7ac365d918644fe65be7d160ef654b27/tests/unit/iris/test_from_iris.py#L111-L119

Not sure why, but this can wait until after v0.1 to fix.

Note on Relevance

It doesn't really matter that unlimited dims aren't set in the ncdata -- they have no meaning outside of a file, so they can just be adjusted before saving.