Python dependecy refactoring

[luisfdez]

Hi Peter,

First of all, do not merge! hehe, it's not yet ready.

This is a big refactoring for handling the python dependencies. They key points are basically:

• I've created a python_dependency.pp class to handle the installation of the dependencies, and it accepts the following types:
  • msi: the given name must match the DisplayName of the package as a normal windows package on puppet.
  • pip: the given name is the name of the pip package, as the pip provider is call. PENDING: make pip available in the system path.
  • exe: the complex one and not yet fully implemented. It basically extract the exe, and copies the following folders. The name given in this case must be the name of the egg-info file. I have to implement the conditions to prevent this case to be executed every puppet run.
  • PLATLIB to C:\Python27\Lib\site-packages (used by all the modules).
  • SCRIPTS to C:\Python27\Scripts (used by pywin32).
  • HEADERS to C:\Python27\ (used by greenlet that needs 'include\greenlet\greenlet.h').
• python.pp: this class now basically installs Python+EasyInstall+Pip and adds references to all the dependencies in the new way.
  • An alternative in this case is to split this class in two: one to install Python+ez+pip, and the other one just to contain the nova dependencies (nova_dependencies.pp?).

What do you think about it? The advantage of this option is that we can reuse a lot of code for each module and it's still flexible enough to launch post-installation scripts like the ones needed by pywin32.

Please, take a look and... show me you feedback!

Saludos!

[luisfdez]

One piece that is missing and I'll push is a refactoring of "download" to let the caller specify the full path of the destination. I'll wait for your feedback before updating the pull.

[luisfdez]

Hi Peter,

I've updated the request. I've managed to make the installation of python dependencies idempotent, so they're not executed if they're already there, maybe it's not the best approach but I think a good beginning for the first version.

It needs more testing and refactoring, but it's a good step forward.

... take a look and test it if you have time or merge it.

The rest of the week I'll continue improving this and other refactoring. Also, I want to get ride of the classes that install optional tools like notepad++, chrome, etc, is it ok for you?

Cheers, Luis

[luisfdez]

More refactoring and some improvements :)...

Copying the commit message:

• python class refactoring:
  • python\install.pp -> installs python, pip and ez + path configuration
  • python\dependency.pp -> abstraction for python dependency.
  • nova_dependencies.pp -> refactoring and resources ordering
• extract_file command extracted to independent file in base/extract_file.pp
  • Contains 7zip installation
• download command now extracted to independent file in base/remote_file.pp
• commands.pp deleted, al relevant commands are now independent defines.
• init.pp: cleaning and referencing new nova_dependencies.
• removed some tools references: 7z (in extract now), gchrome, notpad, vcpp, vexa.

[luisfdez]

Uop... sorry for the close/reoponed changes...

[luisfdez]

Now, I'm focused on extracting as much parameters as possible to allow the user to specify the sources easily. Anyway, you can merge the current version.

[ppouliot]

Merging it in.

p