Closed luisfdez closed 11 years ago
FYI observe this error, looking into it Invalid resource type commands::download at C:/ProgramData/PuppetLabs/puppet/etc/modules/openstack_hyper_v/manifests/tools/git.pp:16
Above reported error can be fixed by using remote_file class, after fixing this it works. nova-compute is installed and service is running openstack_hyper_v::base::remote_file{'Git': source => $git_url, destination => "${::temp}\${git_file}", before => Package['Git version 1.8.0-preview201221022'], }
package { 'Git version 1.8.0-preview201221022': ensure => installed, source => "${::temp}\${git_file}", install_options => ['/VERYSILENT','/SUPPRESSMSGBOXES','/LOG'],
}
Filed issue for it "Issue #37. "
There is a minor issue in init.pp, missing colon ":"
vcsrepo { "${::temp}\nova-clone"
@vijaytripathi , I've updated the PR fixing the bugs you reported. Please, take a look to see if it's ok. Cheers, Luis
Luis,
Can we move the git bits to the windows-git module and use that that as a dep?
This way we can maintain it there and it will be cleaner in the long run. Also we can do the same for remote_file and move it to the windows_common module.
p
Yes, I'll update both... this was just a quick test to see if it was feasible to implement.
I've updated the PR, now it's using... ..._windowsgit (I also sent a PR to this one to use... ..._windowscommon (where I also sent a PR to add 'remote_file') )
Hi, I don't know if someone is taking a look to building from source nova. I submitted this patch as a first draft of how nova can be built from source without depending on the egg file.
Please take a look and test if possible. @vijaytripathi, would you have time to give it a try?
Anyway, let's wait for some testing before merging...
Have a nice weekend :)