search

ppp-project / ppp

Paul's PPP Package: PPP daemon and associated utilities | Official GitHub repo: https://github.com/ppp-project/ppp
https://github.com/ppp-project/ppp
Other
391 stars 232 forks source link

coverity scan #394

Closed chipitsine closed 1 year ago

chipitsine commented 1 year ago

Hello, @paulusmack , @enaess

I've prepared coverity scan project and ran first build https://scan.coverity.com/projects/pppd

feel free to request access, I'll approve it

there are things to review before 2.5.0

image

enaess commented 1 year ago

While fixing some of these make sense. It probably would make more sense to add them to a CI build on GitHub / Master branch / weekly schedule?

It maybe enable on coverity branch, which follows master, but only builds when you copy all of master into that coverity branch to check?

chipitsine commented 1 year ago

I would stay with weekly schedule for master branch, if you fine with separate "coverity" branch, it is ok for me as well

chipitsine commented 1 year ago

I ran scan using the following pipeline: https://github.com/chipitsine/ppp/blob/ab16287327dea92339cd33d90821207b1caee864/.github/workflows/coverity.yml

I tried to rewrite it using non travis guide, it did not work so far: https://github.com/chipitsine/ppp/blob/master/.github/workflows/coverity.yml

chipitsine commented 1 year ago

also, I noticed that pppd was built with some features/libs disabled

ppp version 2.5.0
...
    With libpam..........: no
...
    With libsrp..........: no
...

Features enabled
...
    CBCP.................: no
...

I'll try to enable them to see whether build coverage will increase or not

enaess commented 1 year ago

Don't bother with the libsrp, also the cbcp protocol isn't frequently used. You could install libatm-dev, the it would exclude a bunch of the ATM code in the plugins. Then enable multilink would probably be good