ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
970 stars 381 forks source link

API v2: genre and language fields missing from beatmaps responses #10726

Open MrHeliX opened 10 months ago

MrHeliX commented 10 months ago

In the deprecated osu! API, using the /api/get_beatmaps endpoint, you will receive, among others, the following fields:

{
    "genre_id": "2", // 0 = any, 1 = unspecified, 2 = video game, 3 = anime, 4 = rock, 5 = pop, 6 = other, 7 = novelty, 9 = hip hop, 10 = electronic, 11 = metal, 12 = classical, 13 = folk, 14 = jazz (note that there's no 8)
    "language_id": "5", // 0 = any, 1 = unspecified, 2 = english, 3 = japanese, 4 = chinese, 5 = instrumental, 6 = korean, 7 = french, 8 = german, 9 = swedish, 10 = spanish, 11 = italian, 12 = russian, 13 = polish, 14 = other
}

In the v2 API, these fields are missing from both the Beatmap(set) and Beatmap(set)Extended objects. I would like to see these fields added to the v2 API responses as well

notbakaneko commented 10 months ago

genre and language are part of the detailed GET api/v2/beatmapsets/{beatmapset} response, they're not included in listing responses

MrHeliX commented 10 months ago

Yeah I'm aware they're not included, that's why I created the issue :)