Unmarked featured artist maps

NoffyNoffeh commented 3 years ago

It's been a week and from what I recall, we were asked to wait a week before reporting on unmarked FA maps. So here's a list?

google sheet

This list covers 499 ranked and loved maps of featured artist tracks which are not marked as featured artist on the website. I arbitrarily stopped at 499, this list is not fully comprehensive of all unmarked maps. I estimate over a third of all Featured Artist maps of licensed tracks are unmarked.

For tracks with multiple FAs I list only the first. Not sure how this is handled otherwise.

Common issues:

Featured artist listing has a / between aliases. The map states only the alias which the song was released under in its artist field. The map ends up unmarked.
There is minor formatting differences.
(Cut Ver.) maps are not marked
Featured artist collabs with another artist, such as with a feat. or other indicative symbol in the artist field. These maps end up unmarked.
Markers for length versions, remixes, etc, are usually in light gray text on the FA listing, but are given as (marker) or similar in the template. Maps of these tracks with (marker) do not get marked.
Group FAs such as High Tea, MOtOLOiD, Rising Sun Traxx, Tiny Waves, are completely unmarked due to the actual artists being completely different from the FA name.
The FA listing and template had errors which were previously fixed in the template, but not on the listing. Or they were not fixed at all, while the ranked/loved map is correct.
The track on the FA listing has its title in Japanese, such as *namirin and Trial & Error. Not sure why this leads to unmarked maps.
The ranked/loved map has incorrect metadata (usually maps from before an artist was licensed.)

There is easily another 500 more or more of these, improvement is definitely needed in this area. I'm not sure what needs to be done here as the criteria for maps being marked is not publicized. Even when improvements are made, there needs to be a central location to be able to report unmarked maps so they can be fixed and linked to the Featured Artist listing, as with so many tracks and so many possible tiny variations, it seems impossible to cover every possible case automatically.

peppy commented 3 years ago

No changes have been made to the initial implementation yet. So it can be expected that no changes have been made yet. Please wait a bit longer for this to happen.

Featured artist beatmaps are sourced from ground truth .osz files. Metadata of beatmaps should match them. As long as this matches there should be no issue. If you are to report issues for now, I'd recommend reporting issues with the template files.

For now, to keep traffic low, please keep reports to issues with the templates or listings.

NoffyNoffeh commented 3 years ago

The osz files? That doesn't seem right, dozens of items in the list already match the FA osz templates but aren't marked. See for example the Aitsuki Nakuru maps or the Loki / Thaehan maps.

Is there some place to track the status in terms of waiting?

peppy commented 3 years ago

Let me try again:

For now, please only report issues with the listing or templates rather than beatmaps. These are not yet being used, but that is considered the source of ground truth which will be used going forward.

Tracking waiting can be done by looking at my (private) todo list. So unfortunately not, but I have the task scheduled for this weekend.

peppy commented 3 years ago

An initial pass has been made to catch the more common issues (1752 -> 2168 for ranked/loved). I haven't gone through your spreadsheet yet, but it'd be appreciated if you can update it as above (listing any FA-side issues) and maybe a bullet point list of any remaining common failure cases (with one beatmap example max). No need for huge lists.

NoffyNoffeh commented 3 years ago

Emille's Moonlight Serenade maps match the osz but aren't getting marked. May be due to the FA name (Emille's Moonlight Serenade) and osz name (Emiru no Aishita Tsukiyo ni Dai San Gensou Kyoku wo) being different and the FA having no collabs and no featured singers. Template oszs and ranked maps match and are correct. Similar cases are popping up for other solo FAs which have a few songs with different aliases. Example 1, Example 2
Matching seems to be case sensitive when it doesn't need to be. See Kuba Oms maps or https://osu.ppy.sh/beatmapsets/21178#osu/86531 vs. https://osu.ppy.sh/beatmapsets/757813#osu/1596819 (Cranky changed his alias, old map follows old lowercase alias). Ranked Kuba Oms maps correctly follow sources from Kuba Oms so the template osz files should be updated regardless, but being case-sensitive still doesn't seem neccessary here.
Other maps aren't being picked up despite matching osz, looks like in a lot of cases they have special characters in the title or artist. Examples: https://osu.ppy.sh/beatmapsets/1393933#fruits/2882490, https://osu.ppy.sh/beatmapsets/955671#osu/1997225

Full list of maps found so far which match the template and are unmarked: reference I'm mainly linking this because the reasons why they're unmarked is just guess work and would need further investigation..

I'm working with eiri- to compile FA osz template issues for later, but these are some common cases with already matching map and template which were noticed.

peppy commented 3 years ago

Ah, case sensitivity was one on my list I completely forgot to apply. That's added an additional couple of hundred mappings (have re-run since).

The metadata issues you point out so fare are going to be resolved in a pass we need to do of some older artists where osz don't match databased metadata.

peppy commented 3 years ago

I've added some better handling when .osz doesn't match database, should have caught a lot of the edge cases you mentioned above. 37 new tracks matched.

Hiviexd commented 3 years ago

hi, I found a false positive that's related to the FA tag: https://osu.ppy.sh/beatmapsets/373414#taiko/818079

pretty sure toby fox isn't a featured artist, and clicking the tag sends you to Camellia's FA page

peppy commented 3 years ago

Thanks, will add a rule against matching on remixes like that (camellia has a remix of that track)

peppy commented 3 years ago

All of the issues mentioned in https://github.com/ppy/osu-web/issues/8111#issuecomment-917548467 have been resolved. Let me know if you find any more.

AncuL001 commented 3 years ago

false positive : https://osu.ppy.sh/beatmapsets/1329045#osu/2753127 the remix of this song isn't on the FA

peppy commented 3 years ago

Thanks, I've unmarked that beatmap and adjusted the rules to better handle remixes (again).

JBHyperion commented 3 years ago

Found a couple of missing MIMI sets for "Nanimo Nai Youna". Based on beatmapset discussion, seems to be a romanization error on the osz/listing, which reads "Nani mo Nai Youna" (with an additional space): https://osu.ppy.sh/beatmapsets/1151466/discussion/-/generalAll#/1557587

https://osu.ppy.sh/beatmapsets/1151466 https://osu.ppy.sh/beatmapsets/1197461

Nivalyx commented 3 years ago

@peppy would like to report some potential cases of false positives that i found regarding the song "Yuyoyuppe - Palette" :

1) Yuyoyuppe feat. Hanatan - Palette (http://osu.ppy.sh/s/15951)

this version of the song is an utaite cover of the original vocaloid version (which is licensed), yet somehow it is still tagged as "Featured Artist" in the website. not sure if this is intended behaviour or not tho

2) Yuyoyuppe - Palette GAMMA (http://osu.ppy.sh/s/409429 / http://osu.ppy.sh/s/679239)

...yeah, i'm pretty sure this one is just a (fanmade?) speed up edit of the song of some sort and by any means not official ;~;

LittleEndu commented 3 years ago

None of the maps that appear in rejection's news post are actually marked as featured artist maps. All are of the same song, "Signal feat. Such" which appears to be licensed:

https://osu.ppy.sh/s/1286349
https://osu.ppy.sh/s/1241769
https://osu.ppy.sh/s/1104277
https://osu.ppy.sh/s/1129636
https://osu.ppy.sh/s/1190233

Also, can we get confirmation that the detection is run automatically after a new artist is announced? Like how long should we wait to report issues with new artists?

peppy commented 3 years ago

You should not report issues for new artists. That's out of scope of this thread. Please read my previous comments on what should be posted in this thread.

NoffyNoffeh commented 3 years ago

In addition to the ones Niva mentioned, for ones that are falsely flagged or unflagged

Other false flags https://osu.ppy.sh/beatmapsets/847415#osu/2177436 the version with this featured singer is not licensed https://osu.ppy.sh/beatmapsets/1350334#taiko/2818161 this version is a remaster (indicated by the title changed to remind) and is not licensed. https://osu.ppy.sh/beatmapsets/1388590#osu/2867851 this is a remix of the licensed song, it itself is not licensed
Unflagged https://osu.ppy.sh/beatmapsets/1388993#osu/2868551 matches template osz but not tagged for some reason? https://osu.ppy.sh/beatmapsets/632589 both songs in the map are licensed, they were originally released together https://www.youtube.com/watch?v=E1JcjRRJMEo but for some reason the featured artist listing split them up into two solo tracks. Maybe a third osz with them together like original release would be a solution? Or some way to account for compilations in general, they do happen, especially with metal artists having part 1 / part 2 songs.
There's also quite a few old ARForest maps which list only the singer as the artist, I wouldn't say the osz templates are wrong for saying ARForest feat. Singer, but the maps weren't wrong back then either. Some way to match for just singer in these cases would be helpful.

https://osu.ppy.sh/beatmapsets/12731#osu/47535 https://osu.ppy.sh/beatmapsets/53519#osu/163054 https://osu.ppy.sh/beatmapsets/91606#osu/248001 https://osu.ppy.sh/beatmapsets/39056#osu/124771 https://osu.ppy.sh/beatmapsets/46223#osu/143989

I'm not sure of the current methodology but I think it could work like

Check if it matches osz
Specifcally check for (Short Ver.) / (Cut Ver.) and match if those are the only difference
For some tracks, have set aliases it could match to besides the osz. Similar could be done for artists. e.g. Template has Someone feat. Somebody - Title. It could match to maps if they have either Someone, Somebody, or Someone feat. Somebody but NOT Someone feat. Anotherperson

It seems like current matching still misses quite a few things and also picks up other remixes and alternate vocal versions incorrectly.

peppy commented 3 years ago

No fix has been applied yet for issues I have not replied to as resolved. Please be patient. No need to attempt to define how the process works as I have that under control.

h3oCharles commented 3 years ago

couple songs didn't get marked that i mapped:

united laos remix https://osu.ppy.sh/beatmapsets/1323369#taiko/2741231

algebra https://osu.ppy.sh/beatmapsets/1285922#taiko/2670153 algebra again but unfinished set https://osu.ppy.sh/beatmapsets/758593#taiko/1595602

peppy commented 3 years ago

Graveyard is out of scope right now.

TheMoMan commented 3 years ago

Another false positive same song as https://github.com/ppy/osu-web/issues/8111#issuecomment-917663262

https://osu.ppy.sh/beatmapsets/750458#osu/1580331

peppy commented 3 years ago

@peppy would like to report some potential cases of false positives that i found regarding the song "Yuyoyuppe - Palette" :

Yuyoyuppe feat. Hanatan - Palette (http://osu.ppy.sh/s/15951)

this version of the song is an utaite cover of the original vocaloid version (which is licensed), yet somehow it is still tagged as "Featured Artist" in the website. not sure if this is intended behaviour or not tho

Yuyoyuppe - Palette GAMMA (http://osu.ppy.sh/s/409429 / http://osu.ppy.sh/s/679239)

...yeah, i'm pretty sure this one is just a (fanmade?) speed up edit of the song of some sort and by any means not official ;~;

I honestly think these kinds of edge cases are fine to leave as is. The artist is featured and the tracks are the correct (base) tracks. The main purpose here is providing visibility, not a perfect 1:1 match. So I'm going to leave these for now.

peppy commented 3 years ago

I've done another update covering hopefully all the issues posted above. Also found around 100 new (ranked) beatmaps in the process.

Please resurface any I may have missed!

peppy commented 3 years ago

@NoffyNoffeh can i assume that silence here means that things are in a good state, or have you just not had a chance to do another pass?

AncuL001 commented 3 years ago

well uh, you still haven't unmarked the glacierfall remix map i linked

peppy commented 3 years ago

Thanks.

That's a pretty low priority since the artist and song are correct but I'll keep that in mind. More interested in tracks which are blatantly wrong (wrong artist or not flagged where they should be).

h3oCharles commented 3 years ago

found another map that isnt marked https://osu.ppy.sh/beatmapsets/875916#osu/2357967

peppy commented 3 years ago

Thanks, that's an edge case that wasn't handled. Will look into it tonight.

Nivalyx commented 3 years ago

found yet another map that are unmarked as of now http://osu.ppy.sh/beatmapsets/1522511#osu/3121000

if any i guess this one's possibly missing the marker due to the (very slight) metadata difference between the beatmap and the fa listing page :

Heaxys commented 2 years ago

Hi, this map of mine has still not been marked until now https://osu.ppy.sh/beatmapsets/1296171

I don't know why tho, formatting is the same, and it got submitted after the band (and the song) got listed

h3oCharles commented 2 years ago

found more maps with questionable markings all are MIMI songs should umu's cover of Ai no Sukima be marked? marked ctb set https://osu.ppy.sh/beatmapsets/1215878#fruits/2530118 sotarks cut https://osu.ppy.sh/beatmapsets/966339#osu/2031676 full ver with sb https://osu.ppy.sh/beatmapsets/1371996#osu/3102474

should Myxo's Rock Cover of Ai no Sukima be marked too? std set https://osu.ppy.sh/beatmapsets/1092468#osu/2283635 taiko set https://osu.ppy.sh/beatmapsets/1096932#taiko/2295515

peppy commented 2 years ago

Thanks for the reports.

While they aren't 100% correct, I'm not sure these edge cases matter too much. They are harder ones to automate because the titles (like "feat. someone") for a cover are not standard - this is most commonly used by an artist for an original track title where the singer wants to be recognised, not a cover.

At the end of the day it does link back to the "original" track, which allows for clarification if a user cares to check.

I guess it does depend on how we use the featured artist badge going forward, and whether having these maps marked as such leads to further confusion.

aryoadhi commented 2 years ago

Thanks for mentioning my issue. As stated on my topic above, there is a chance that a map is falsely marked with Featured Artist listing.

https://osu.ppy.sh/beatmapsets/1667108

Perhaps it's due to the artist involved in remixing uses the template that might conflicts with the webpage's automatic marking system, and my decision to cut the song shortly. The title is:

Getty - Pump It (Serji Remix) (Cut Ver.)

The original source is indeed available on the Featured Artist listing, but this particular remix doesn't. Perhaps it's conflicting too with the suffix (Cut Ver.) attached on my beatmap.

aceredshirt13 commented 2 years ago

Hello! I know this thread is mostly dead, and several of these may have been mentioned here before, but I was told to come here by the NAT when I contacted them about this. The following maps:

https://osu.ppy.sh/beatmapsets/1251607#taiko/2601734 https://osu.ppy.sh/beatmapsets/695743#osu/1554636 https://osu.ppy.sh/beatmapsets/58951#osu/243848 https://osu.ppy.sh/beatmapsets/100016#osu/265590 https://osu.ppy.sh/beatmapsets/114480#osu/296411 https://osu.ppy.sh/beatmapsets/1108252#osu/2327672 https://osu.ppy.sh/beatmapsets/28145#osu/93957

all need to be marked Featured Artist. They all have the aforementioned issues of slight differences in how either the title of the song or the name of the artist is marked, even though they are identical to the songs listed as featured.

peppy commented 2 years ago

@Ephemeralis I think you already looked into this one – did you happen to have a fix lined up? I think you said the beatmap template was actually incorrect.

Ephemeralis commented 2 years ago

I can go through and link them to tracks manually via DB if that won't break anything. This is typically caused by a metadata mismatch - either the beatmapset's metadata is incorrect (likely the case on older ones) or the template on our listing is incorrect (which it shouldn't be and warrants an update to fix).

peppy commented 2 years ago

I mean, depends on which is the case here. Either way, you can make changes at a database level but let me know when you're done as I will need to run reindexing.

Wieku commented 2 years ago

I noticed that some seleP songs are not marked as FA.

https://osu.ppy.sh/beatmapsets/41686 https://osu.ppy.sh/beatmapsets/46623 https://osu.ppy.sh/beatmapsets/20201

Those maps use vocaloid name as artist, seleP is provided in source field. Those 3 songs are in seleP's FA page.

JBHyperion commented 1 year ago

Some Omoi tracks brought to my attention:

Teioh Education - matching FA listing osu | taiko

Snow Drive(01.23) osu - FA listing has an additional space loved - seems to match FA listing

Totsugeki Zenya no Dance - FA listing uses an English translation, "Dance on the Eve of Attack" osu

Kiseki sae mo - FA listing omits a space between "sae" and "mo" osu | taiko

Additionally, still some outstanding MIMI tracks I brought up before that may have been missed.

pishifat commented 1 year ago

tsunamix's songs use a different alias, so none of their ranked maps are marked https://osu.ppy.sh/beatmapsets?q=tsunamix_underground https://osu.ppy.sh/beatmaps/artists/329

and this shouldn't be marked https://osu.ppy.sh/beatmapsets/1414510#taiko/2915513

peppy commented 1 year ago

I've fixed tsunamix. Other fixes will come a bit later.

Shmiklak commented 1 year ago

https://osu.ppy.sh/beatmapsets/1910029#osu/3939705

This is a Monstercat song which didn't receive nor its Featured Artist marker nor Monstercat release marker in game

pishifat commented 1 year ago

everything under "Songs" on the monstercat listing (https://osu.ppy.sh/beatmaps/artists/255) isn't being tagged for whatever reason (including the map commented above) some other examples: https://osu.ppy.sh/beatmapsets/1885930#osu/3883169 https://osu.ppy.sh/beatmapsets/1888841#osu/3890044 https://osu.ppy.sh/beatmapsets/1905153#osu/3928422

op45667 commented 1 year ago

https://osu.ppy.sh/beatmapsets/1897902#taiko/3911679

My map, which was ranked back in December, still hasn't had a featured artist tag added after a minor change (adding a space after a colon for standardization reasons). This is the first ranked map of this song that contains that space, which probably screwed with the FA tagging system.