ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.4k stars 2.29k forks source link

Add support for "explicit content" beatmap markers & warnings #11460

Open frenzibyte opened 3 years ago

frenzibyte commented 3 years ago

Currently going through this one now that it's live web-side, can't assign myself (no perms) so would like somebody to do so.


Also submitting this for feedback/suggestions over how handling should go when attempting to join a room that has an explicit beatmap selected at the moment, or when attempting to spectate a player that is playing an explicit beatmap.

Thinking about going simple and show a warning similar to the beatmap viewing one (show once, disable warning, go back) when attempting to do any of the above operations.

And maybe, if necessary, adding a checkbox to hide any certain room/player that is involved with an explicit beatmap. (can just use the user's configuration towards explicit content for hiding as well), what do you think?

bdach commented 3 years ago

I think the scope of this issue might be reaching a bit far to be honest. This is definitely not something that will be resolved by a single pull.

Should probably begin with beatmap listing and beatmap overlays.

frenzibyte commented 3 years ago

Yeah, I submitted this for suggestions on the above and to mark out that I've been working on this. (for the record, I'm finished with beatmap listing and overlay stuff, will PR them out tomorrow)

Gamingzone123 commented 2 years ago

Should probably have a setting to ignore the explicit content warning, a bit like how you can set listings to show explicit beatmaps regardless, on that note should probably have a setting for the epilepsy warning too, but that's another issue

bdach commented 2 years ago

@Gamingzone123 did you perhaps miss this?

2022-02-21-224846_521x465_scrot

Gamingzone123 commented 2 years ago

I was talking about in-game when starting the beatmap

mk56-spn commented 2 years ago

seems kinda pointless since the NSFW backgrounds show in song select

Userlog2 commented 3 weeks ago

seems kinda pointless since the NSFW backgrounds show in song select

Almost all "Explicit" marks refer to Explicit lyrics. An idea could be that Explicit songs are muted in song select unless the user changes a setting to play them automatically like other songs.