pradt2 / always-online-stun

A list of publicly available STUN servers, refreshed every hour.
MIT License
573 stars 49 forks source link

Incorrect public client address returned by some servers #18

Closed Aldaviva closed 5 months ago

Aldaviva commented 5 months ago

Hello,

Thanks for providing this list.

When using random STUN servers from this list, I found that some of the servers returned incorrect public client IP addresses in response to binding test requests. The remaining hundreds of servers consistently return my correct public IP address, so I believe my STUN client is operating properly.

Servers that return incorrect results

They returned 16 incorrect addresses over 8 days.

I see in the readme that you automatically check for a correct binding response before adding a server to the Valid lists, so I'm not sure if the incorrect behavior of these servers in intermittent, or maybe only appears for some users, or some other reason I haven't thought of.

I have blocked my client from using these two hostnames in STUN requests, but you may want to remove them from your candidate set to avoid causing problems for other users.

Thanks.

pradt2 commented 5 months ago

Hi,

Thanks for submitting this issue. I'll remove these servers from the automated checks straight away.

Just for my own curiosity, can you tell me more about the incorrect results returned by these services? Were they still within the range that was expected (e.g. 100.101.102.103 vs 100.101.102.104) or completely different?

I'm thinking that maybe what you observed was just a weird/interesting behaviour on the NAT part rather than anything to do with the STUN servers themselves. However, if that were the case, you'd see other services return wrong IP addresses too, which doesn't seem to be the case.

pradt2 commented 5 months ago

I have removed the two services from the candidates list. They will be removed from the valid lists at the next automated check in about 1h.

Aldaviva commented 5 months ago

Thanks!

Here are the incorrect IP addresses they returned. My correct WAN IP address was in the 73.202.30.0/24 subnet at the time.

pradt2 commented 5 months ago

Okay, this is very strange, these IP addresses are all over the place.

Thanks again for spotting this!