search

pradyunsg / furo

A clean customizable documentation theme for Sphinx
https://pradyunsg.me/furo/quickstart
MIT License
2.81k stars 321 forks source link

[docs example confusion report] Dark vs. light image examples shouldn't look the same #836

Open pradyunsg opened 2 months ago

pradyunsg commented 2 months ago

Discussed in https://github.com/pradyunsg/furo/discussions/835

Originally posted by **webknjaz** September 3, 2024 I was just showing https://pradyunsg.me/furo/reference/images/#different-images-for-dark-light-mode to a tech writer and wanted to demonstrate that toggling the mode at the top of that web page changes images. I was expecting that the difference would be visible, but the images looked the same. It took a minute to figure out the confusion — the image URLs are the same and the image is not different in any of the variants of this example. I propose switching the example image to be different for dark vs. light modes. And additionally, it'd be good to use different images for `image` vs. `figure`.
pradyunsg commented 2 months ago

A PR fixing this would be welcome.