search

prashnts / pybloomfiltermmap3

Fast Python Bloom Filter using Mmap
https://github.com/prashnts/pybloomfiltermmap3
MIT License
130 stars 24 forks source link

BloomFilter().name returns encoded string #16

Closed mizvyt closed 4 years ago

mizvyt commented 5 years ago

I'd normally expect a string instance, instead I get bytes. My suggestion is to leave this as it is, but issue a DeprecationWarning in the 0.5.0 release, for the next minor version (0.6.0 or smth).

Would BloomFilter().filename make more sense? Then no breaking changes would need to be made until then.

prashnts commented 5 years ago

I'd normally expect a string instance, instead I get bytes.

I'd expect the same. .filename sounds good -- sorta a middle ground between breaking changes vs. api improvement.

mizvyt commented 4 years ago

0.5.2 is out with the fix.