search

prashnts / pybloomfiltermmap3

Fast Python Bloom Filter using Mmap
https://github.com/prashnts/pybloomfiltermmap3
MIT License
130 stars 24 forks source link

Can we include bit array as a property of Bloom Filter? #19

Closed AaronRanAn closed 4 years ago

AaronRanAn commented 4 years ago

Most the original python Bloom Filter implementation includes the bit vector representation as a property, as in BloomFilter.bitarray. This has two major benefits:

1) Further bit-wise application can be easily carried out, such as cardinality estimation for union, inspection of Bloom Filters, flipping Bloom Filter bit with a small probability. 2) Easily debug and explain to people how Bloom Filter looks and works.

Can we add bit vector/array as a property for pybloomfiltermmap3's Bloom Filter as well? Since pybloomfiltermmap3 has become one of the most modern and scalable python BF implementation.

Thanks for considering!

cc. @mizvyt for discussion in axiak/pybloomfiltermmap.

mizvyt commented 4 years ago

I've created a PR for this. See my comments there also.

mizvyt commented 4 years ago

0.5.2 is out with the feature.