Open lipov3cz3k opened 1 year ago
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
2c8bfec
) 85.91% compared to head (d383afb
) 85.81%.
Files | Patch % | Lines |
---|---|---|
controllers/zookeepercluster_controller.go | 69.23% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I also experienced this multiple times. Have to explicitly use non-cascading delete for it to work. Can someone please review and approve this?
@lipov3cz3k can you perhaps fix the two failed tests "DCO" and "codecov/patch", so it is more likely that the maintainers can approve and merge this?
@lipov3cz3k Could you please increase the code coverage?
@lipov3cz3k Is it possible to increase the coverage?
Change log description
Fix unexpected resource creation when the ZookeeperCluster is already deleted
Purpose of the change
Fixes #410
What the code does
Exit reconcile when resource has finalizer and is marked for delete. That's prevent to apply other reconcile functions to create already deleted resources.
How to verify it
Delete
zookeepercluster
resource inforeground
mode -> without this patch it goes to loop (you can fix it by deleting zookeeper in defaultbackground
mode)