search

prawnpdf / pdf-inspector

A collection of PDF::Reader based analysis classes for inspecting PDF output. Mainly used for testing Prawn, but will work with any PDF.
http://prawnpdf.org
Other
155 stars 33 forks source link

Add support for horizontal text scaling. #22

Closed msbit closed 7 years ago

msbit commented 8 years ago

Add methods and attrs for storing and inspecting horizontal text scaling references.

pointlessone commented 8 years ago

@msbit Thank you for all the contributions you've made recently.

Specs? ;)

msbit commented 8 years ago

Can write some if you want, was taking my cue from the fact that there were none there already :smiley:

pointlessone commented 8 years ago

I know the coverage is not very good, to say the least. We should strive for better. ;)

msbit commented 8 years ago

So, as you may have guessed from my other PR on pdf-core, my motivation is to get horizontal text scaling going in prawn itself.

From my testing it's working, and in order to get the specs running for that change, pdf-inspector needed to be able to keep track of horizontal scaling changes coming in from pdf-reader.

I'm not, however, especially au fait with how pdf-inspector and pdf-reader work together, so I'm probably not the right person to start getting the testing in place for this gem. I can definitely add to the specs once something is in place.

msbit commented 8 years ago

Bit the bullet and wrote some specs for easily settable text attributes (character spacing and horizontal text scaling).

pointlessone commented 8 years ago

@msbit This gem is mostly used in specs elsewhere. Could you please reference relevant PRs on other gems if there are any? Just so that we knew we need to merge this one before the PRs that depend on it.

msbit commented 8 years ago

No outstanding PRs in other projects rely on this.

Once this and my two other PRs for pdf-core (https://github.com/prawnpdf/pdf-core/pull/26 and https://github.com/prawnpdf/pdf-core/pull/27) are tagged and versioned, I've got a branch on my fork of prawn that I'll put forward as a PR.

msbit commented 7 years ago

👍