pre-commit / pre-commit-hooks

Some out-of-the-box hooks for pre-commit
MIT License
5.4k stars 710 forks source link

check-illegal-windows-names hook does not exist #1091

Closed madpipeline closed 2 months ago

madpipeline commented 2 months ago
$ pre-commit autoupdate
[https://github.com/pre-commit/pre-commit-hooks] Cannot update because the update target is missing these hooks: check-illegal-windows-names

Running on version v4.6.0

asottile commented 2 months ago

search the issue tracker next time!

madpipeline commented 2 months ago

There are 2 other closed issues on the topic, none of which have an explanation as to why a hook is documented as available but the latest release of pre-commit does not have it, nor is it present in the main branch.

While this issue and https://github.com/pre-commit/pre-commit-hooks/issues/1046 are duplicates of https://github.com/pre-commit/pre-commit-hooks/issues/1043 none of them have an explanation about the discrepancy between the documentation and the current release.

If the case is that

"perhaps it's in a newer version" yes not released yet

then the hook should not be documented as available, until the hook is released.

P.S. While I do understand that it's annoying to have duplicate issues pop up, that is no reason to get aggressive, when after 5 months of reporting, people still try to use a documented hook that is in fact not available.

asottile commented 2 months ago

good job you found the answer! you just don't like it and that's fine but please don't open an issue next time when the answer is right there